Skip to content

Commit 4a1f0ce

Browse files
committed
Updated code based on review of Adam
1 parent 53b5deb commit 4a1f0ce

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

exist-core/src/main/java/org/exist/storage/NativeBroker.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,7 @@ public class NativeBroker extends DBBroker {
175175

176176
private final NodeProcessor nodeProcessor = new NodeProcessor();
177177

178-
private final IEmbeddedXMLStreamReader streamReader = null;
179-
private IEmbeddedXMLStreamReader streamReaderNG = null;
178+
private IEmbeddedXMLStreamReader streamReader;
180179

181180
private final LockManager lockManager;
182181
private final Optional<JournalManager> logManager;
@@ -480,13 +479,13 @@ public NativeValueIndex getValueIndex() {
480479
@Override
481480
public IEmbeddedXMLStreamReader getXMLStreamReader(final NodeHandle node, final boolean reportAttributes)
482481
throws IOException, XMLStreamException {
483-
if(streamReaderNG == null) {
482+
if(streamReader == null) {
484483
final RawNodeIterator iterator = new RawNodeIterator(this, domDb, node);
485-
streamReaderNG = new EmbeddedXMLStreamReader(this, node.getOwnerDocument(), iterator, node, reportAttributes);
484+
streamReader = new EmbeddedXMLStreamReader(this, node.getOwnerDocument(), iterator, node, reportAttributes);
486485
} else {
487-
streamReaderNG.reposition(this, node, reportAttributes);
486+
streamReader.reposition(this, node, reportAttributes);
488487
}
489-
return streamReaderNG;
488+
return streamReader;
490489
}
491490

492491
@Override

exist-core/src/main/java/org/exist/xupdate/Modification.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -204,12 +204,9 @@ protected void declareVariables(XQueryContext context) throws XPathException {
204204
* @throws XPathException if an error occurs whilst declaring the namespaces
205205
*/
206206
protected void declareNamespaces(XQueryContext context) throws XPathException {
207-
Map.Entry<String, String> entry;
208-
for (Map.Entry<String, String> stringStringEntry : namespaces.entrySet()) {
209-
entry = stringStringEntry;
210-
context.declareNamespace(
211-
entry.getKey(),
212-
entry.getValue());
207+
208+
for (Map.Entry<String, String> entry : namespaces.entrySet()) {
209+
context.declareNamespace(entry.getKey(), entry.getValue());
213210
}
214211
}
215212

0 commit comments

Comments
 (0)