[bugfix] fn:transform URI resolution

Improve comments and code formatting

Author: alanpaxton

exist-core/src/main/java/org/exist/util/SaxonConfiguration.java

@@ -54,7 +54,8 @@ public final class SaxonConfiguration {
   private SaxonConfiguration(final net.sf.saxon.Configuration configuration) {
     this.configuration = configuration;
     this.processor = new Processor(configuration);
-    //TODO (AP) We could further configure URI/Resource resolution for Saxon within eXist here
+    //TODO (AP) This is a better place to configure URI/Resource resolution for Saxon within eXist
+    //At present the configuration for Saxon to resolve xmldb:exist: URIs is restricted to fn:transform
   }
 
   /**

exist-core/src/main/java/org/exist/xquery/functions/fn/transform/URIResolution.java

@@ -88,15 +88,11 @@ public Source resolve(final String href, final String base) throws TransformerEx
                 var resolved = resolveURI(hrefURI, baseURI);
                 return resolveDocument(resolved.getStringValue());
             } catch (URISyntaxException e) {
-                throw new TransformerException("Failed to resolve " +
-                    href +
-                    " against " +
-                    base, e);
-            } catch (org.exist.xquery.XPathException e) {
-                throw new TransformerException("Failed to find document as result of resolving " +
-                    href +
-                    " against " +
-                    base, e);
+                throw new TransformerException(
+                    "Failed to resolve " + href + " against " + base, e);
+            } catch (XPathException e) {
+                throw new TransformerException(
+                    "Failed to find document as result of resolving " + href + " against " + base, e);
             }
         }
 

exist-core/src/test/java/org/exist/xquery/functions/fn/transform/FunTransformTest.java

@@ -166,11 +166,12 @@ private static class SourceWithLocation implements Source {
             this.location = location;
         }
 
+        // implementation solely to conform to interface for test use
         @Override
         public void setSystemId(String systemId) {
-
         }
 
+        // implementation solely to conform to interface for test use
         @Override
         public String getSystemId() {
             return null;