[bugfix] Ensure the journal file is closed if an error occurs when opening it

adamretter · adamretter · commit 5ac76940e2ce · 2018-10-31T14:33:49.000+08:00
diff --git a/src/org/exist/storage/journal/JournalReader.java b/src/org/exist/storage/journal/JournalReader.java
@@ -65,8 +65,9 @@ public JournalReader(final DBBroker broker, final Path file, final int fileNumbe
         this.broker = broker;
         this.fileNumber = fileNumber;
         try {
-            fc = Files.newByteChannel(file, READ);
+            this.fc = Files.newByteChannel(file, READ);
         } catch (final IOException e) {
+            close();
             throw new LogException("Failed to read journal file " + file.toAbsolutePath().toString(), e);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,9 @@ public JournalReader(final DBBroker broker, final Path file, final int fileNumbe`
`65`	`65`	`this.broker = broker;`
`66`	`66`	`this.fileNumber = fileNumber;`
`67`	`67`	`try {`
`68`		`- fc = Files.newByteChannel(file, READ);`
	`68`	`+ this.fc = Files.newByteChannel(file, READ);`
`69`	`69`	`} catch (final IOException e) {`
	`70`	`+ close();`
`70`	`71`	`throw new LogException("Failed to read journal file " + file.toAbsolutePath().toString(), e);`
`71`	`72`	`}`
`72`	`73`	`}`