Skip to content

Commit 5bc3019

Browse files
duncdrumline-o
authored andcommitted
[refactor] remove dead code
dependencies are part of distroless base image enable experimental image push for testing
1 parent bac6441 commit 5bc3019

File tree

2 files changed

+8
-26
lines changed

2 files changed

+8
-26
lines changed

.github/workflows/ci-deploy.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@ jobs:
6060
run: mvn -q -Ddocker.tag=release -Ddocker.username=$DOCKER_USERNAME -Ddocker.password=$DOCKER_PASSWORD docker:build docker:push
6161
working-directory: ./exist-docker
6262
# NOTE (DP): This is for debugging, publishes an experimental image from inside PRs against develop
63-
# - name: Publish experimental images
64-
# if: github.base_ref == 'develop'
65-
# env:
66-
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
67-
# DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
68-
# DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
69-
# run: mvn -q -Ddocker.tag=experimental -Ddocker.username=$DOCKER_USERNAME -Ddocker.password=$DOCKER_PASSWORD docker:build docker:push
70-
# working-directory: ./exist-docker
63+
- name: Publish experimental images
64+
if: github.base_ref == 'develop'
65+
env:
66+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
67+
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
68+
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
69+
run: mvn -q -Ddocker.tag=experimental -Ddocker.username=$DOCKER_USERNAME -Ddocker.password=$DOCKER_PASSWORD docker:build docker:push
70+
working-directory: ./exist-docker
7171

exist-docker/src/main/resources-filtered/Dockerfile

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -20,26 +20,8 @@
2020
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2121
#
2222

23-
# Use Debian Bullseye (which is the base of gcr.io/distroless/java:17) for additional library dependencies that we need
24-
# FROM debian:bullseye-slim as debian-slim
25-
# RUN apt-get update && apt-get -y dist-upgrade
26-
# RUN apt-get install -y openjdk-17-jre-headless
27-
# RUN apt-get install -y expat fontconfig # Install tools required by FOP
28-
2923
FROM gcr.io/distroless/java17:latest
3024

31-
# Copy over dependencies for Apache FOP, missing from GCR's JRE
32-
# COPY --from=debian-slim /usr/lib/x86_64-linux-gnu/libfreetype.so.6 /usr/lib/x86_64-linux-gnu/libfreetype.so.6
33-
# COPY --from=debian-slim /usr/lib/x86_64-linux-gnu/liblcms2.so.2 /usr/lib/x86_64-linux-gnu/liblcms2.so.2
34-
# COPY --from=debian-slim /usr/lib/x86_64-linux-gnu/libpng16.so.16 /usr/lib/x86_64-linux-gnu/libpng16.so.16
35-
# COPY --from=debian-slim /usr/lib/x86_64-linux-gnu/libfontconfig.so.1 /usr/lib/x86_64-linux-gnu/libfontconfig.so.1
36-
37-
# Copy dependencies for Apache Batik (used by Apache FOP to handle SVG rendering)
38-
# COPY --from=debian-slim /etc/fonts /etc/fonts
39-
# COPY --from=debian-slim /lib/x86_64-linux-gnu/libexpat.so.1 /lib/x86_64-linux-gnu/libexpat.so.1
40-
# COPY --from=debian-slim /usr/share/fontconfig /usr/share/fontconfig
41-
# COPY --from=debian-slim /usr/share/fonts/truetype/dejavu /usr/share/fonts/truetype/dejavu
42-
4325
# Copy eXist-db
4426
COPY LICENSE /exist/LICENSE
4527
COPY autodeploy /exist/autodeploy

0 commit comments

Comments
 (0)