Skip to content

Commit 5cd0c6e

Browse files
committed
[refactor] Java8: Replace with simple Map method call
1 parent 4e690d9 commit 5cd0c6e

File tree

4 files changed

+7
-22
lines changed

4 files changed

+7
-22
lines changed

exist-core/src/main/java/org/exist/management/impl/JMXAgent.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ public synchronized void initDBInstance(final BrokerPool instance) {
9393
try {
9494
addMBean(perInstanceMBean);
9595
} catch (final DatabaseConfigurationException e) {
96-
LOG.warn("Exception while registering JMX MBean: {}, for database: {}.", perInstanceMBean.getClass().getName(), instance.getId(), e);
96+
LOG.warn("Exception while registering JMX MBean: {}, for database: {}.",
97+
perInstanceMBean.getClass().getName(), instance.getId(), e);
9798
}
9899
}
99100
}
@@ -116,11 +117,7 @@ public synchronized void addMBean(final PerInstanceMBean mbean) throws DatabaseC
116117
try {
117118
addMBean(mbean.getName(), mbean);
118119
if (mbean.getInstanceId() != null) {
119-
Deque<ObjectName> stack = registeredMBeans.get(mbean.getInstanceId());
120-
if (stack == null) {
121-
stack = new ArrayDeque<>();
122-
registeredMBeans.put(mbean.getInstanceId(), stack);
123-
}
120+
Deque<ObjectName> stack = registeredMBeans.computeIfAbsent(mbean.getInstanceId(), k -> new ArrayDeque<>());
124121
stack.push(mbean.getName());
125122
}
126123
beanInstances.put(mbean.getName(), mbean);

exist-core/src/main/java/org/exist/storage/lock/LockTable.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,8 @@ private void event(final LockEventType lockEventType, final long groupId, final
171171
switch (lockEventType) {
172172
case Attempt:
173173

174-
Entry entry = attempting.get(currentThread);
175-
if (entry == null) {
176-
// happens once per thread!
177-
entry = new Entry();
178-
attempting.put(currentThread, entry);
179-
}
174+
// happens once per thread!
175+
Entry entry = attempting.computeIfAbsent(currentThread, k -> new Entry());
180176

181177
entry.id = id;
182178
entry.lockType = lockType;

exist-core/src/main/java/org/exist/xquery/AbstractInternalModule.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -179,11 +179,7 @@ public Iterator<QName> getGlobalVariables() {
179179
@Override
180180
public Variable declareVariable(final QName qname, final Object value) throws XPathException {
181181
final Sequence val = XPathUtil.javaObjectToXPath(value, null, null);
182-
Variable var = mGlobalVariables.get(qname);
183-
if (var == null){
184-
var = new VariableImpl(qname);
185-
mGlobalVariables.put(qname, var);
186-
}
182+
Variable var = mGlobalVariables.computeIfAbsent(qname, VariableImpl::new);
187183
var.setValue(val);
188184
return var;
189185
}

exist-core/src/main/java/org/exist/xquery/ExternalModuleImpl.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,11 +188,7 @@ public Collection<VariableDeclaration> getVariableDeclarations() {
188188
*/
189189
public Variable declareVariable(QName qname, Object value) throws XPathException {
190190
final Sequence val = XPathUtil.javaObjectToXPath(value, mContext, null);
191-
Variable var = mStaticVariables.get(qname);
192-
if (var == null) {
193-
var = new VariableImpl(qname);
194-
mStaticVariables.put(qname, var);
195-
}
191+
Variable var = mStaticVariables.computeIfAbsent(qname, VariableImpl::new);
196192
var.setValue(val);
197193
return var;
198194
}

0 commit comments

Comments
 (0)