Skip to content

Commit 8a952e4

Browse files
committed
Update after feedback
1 parent 39660b7 commit 8a952e4

File tree

3 files changed

+22
-15
lines changed

3 files changed

+22
-15
lines changed

exist-ant/src/main/java/org/exist/ant/XMLDBExtractTask.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@
3636

3737
import java.io.*;
3838

39+
import java.nio.file.Files;
40+
import java.nio.file.Path;
3941
import java.util.Properties;
4042

4143
import javax.xml.transform.OutputKeys;
@@ -260,14 +262,14 @@ private void writeXMLResource(final XMLResource res, final File dest) throws IOE
260262
}
261263
}
262264

263-
private Writer getWriter(XMLResource res, File dest) throws XMLDBException, FileNotFoundException {
265+
private Writer getWriter(XMLResource res, File dest) throws XMLDBException, IOException {
264266
final Writer writer;
265267
if (dest.isDirectory()) {
266-
String fname = res.getId();
267-
final File file = new File(dest, fname);
268-
writer = new OutputStreamWriter(new FileOutputStream(file), UTF_8);
268+
final Path file = dest.toPath().resolve(res.getId());
269+
writer = Files.newBufferedWriter(file, UTF_8);
270+
269271
} else {
270-
writer = new OutputStreamWriter(new FileOutputStream(dest), UTF_8);
272+
writer = Files.newBufferedWriter(destFile.toPath(), UTF_8);
271273
}
272274
return writer;
273275
}

exist-ant/src/main/java/org/exist/ant/XMLDBXPathTask.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838

3939
import java.io.*;
4040

41+
import java.nio.file.Files;
42+
import java.nio.file.Path;
4143
import java.util.Properties;
4244

4345
import javax.xml.transform.OutputKeys;
@@ -193,22 +195,24 @@ private void writeResource(final XMLResource resource, final File dest) throws I
193195
}
194196
}
195197

196-
private Writer getWriter(XMLResource resource, File dest) throws XMLDBException, FileNotFoundException {
198+
private Writer getWriter(XMLResource resource, File dest) throws XMLDBException, IOException {
197199
final Writer writer;
198200
if (dest.isDirectory()) {
199201

200202
if (!dest.exists()) {
201203
dest.mkdirs();
202204
}
203-
String fname = resource.getId();
204205

206+
String fname = resource.getId();
205207
if (!fname.endsWith(".xml")) {
206208
fname += ".xml";
207209
}
208-
final File file = new File(dest, fname);
209-
writer = new OutputStreamWriter(new FileOutputStream(file), UTF_8);
210+
211+
final Path file = dest.toPath().resolve(fname);
212+
writer = Files.newBufferedWriter(file, UTF_8);
213+
210214
} else {
211-
writer = new OutputStreamWriter(new FileOutputStream(dest), UTF_8 );
215+
writer = Files.newBufferedWriter(dest.toPath(), UTF_8);
212216
}
213217
return writer;
214218
}

exist-ant/src/main/java/org/exist/ant/XMLDBXQueryTask.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@
4747

4848
import java.net.URL;
4949

50+
import java.nio.file.Files;
51+
import java.nio.file.Path;
5052
import java.util.ArrayList;
5153
import java.util.List;
5254
import java.util.Properties;
@@ -205,7 +207,7 @@ private void writeResource(final XMLResource resource, final File dest) throws I
205207
}
206208
}
207209

208-
private Writer getWriter(XMLResource resource, File dest) throws XMLDBException, FileNotFoundException {
210+
private Writer getWriter(XMLResource resource, File dest) throws XMLDBException, IOException {
209211
final Writer writer;
210212
if (dest.isDirectory()) {
211213

@@ -214,16 +216,15 @@ private Writer getWriter(XMLResource resource, File dest) throws XMLDBException,
214216
}
215217

216218
String fname = resource.getId();
217-
218219
if (!fname.endsWith(".xml")) {
219220
fname += ".xml";
220221
}
221222

222-
final File file = new File(dest, fname);
223-
writer = new OutputStreamWriter(new FileOutputStream(file), UTF_8);
223+
final Path file = dest.toPath().resolve(fname);
224+
writer = Files.newBufferedWriter(file, UTF_8);
224225

225226
} else {
226-
writer = new OutputStreamWriter(new FileOutputStream(dest), UTF_8);
227+
writer = Files.newBufferedWriter(dest.toPath(), UTF_8);
227228
}
228229
return writer;
229230
}

0 commit comments

Comments
 (0)