[feature] Add missing exist:output-doctype option to fn:serialize

Author: adamretter

exist-core/src/main/java/org/exist/xquery/util/SerializerUtils.java

@@ -185,6 +185,7 @@ public Sequence getDefaultValue() {
      * for Exist xquery specific functions
      */
     public enum ExistParameterConvention implements ParameterConvention<QName> {
+        OUTPUT_DOCTYPE(EXistOutputKeys.OUTPUT_DOCTYPE, Type.BOOLEAN, Cardinality.ZERO_OR_ONE, BooleanValue.FALSE),
         EXPAND_XINCLUDE(EXistOutputKeys.EXPAND_XINCLUDES, Type.BOOLEAN, Cardinality.ZERO_OR_ONE, BooleanValue.TRUE),
         PROCESS_XSL_PI(EXistOutputKeys.PROCESS_XSL_PI, Type.BOOLEAN, Cardinality.ZERO_OR_ONE, BooleanValue.TRUE),
         JSON_IGNORE_WHITE_SPACE_TEXT_NODES(EXistOutputKeys.JSON_IGNORE_WHITESPACE_TEXT_NODES, Type.BOOLEAN, Cardinality.ZERO_OR_ONE, BooleanValue.TRUE),

exist-core/src/test/xquery/xquery3/serialize.xql

@@ -132,6 +132,8 @@ declare variable $ser:test-xml := document {
     <elem a="abc"><!--comment--><b>123</b></elem>
 };
 
+declare variable $ser:test-xml-with-doctype := '<!DOCTYPE bookmap PUBLIC "-//OASIS//DTD DITA BookMap//EN" "bookmap.dtd"><bookmap id="bookmap-1"/>';
+
 declare variable $ser:collection-name := "serialization-test";
 
 declare variable $ser:collection := "/db/" || $ser:collection-name;
@@ -142,7 +144,8 @@ function ser:setup() {
     xmldb:create-collection("/db", $ser:collection-name),
     xmldb:store($ser:collection, "test.xml", $ser:test-xml),
     xmldb:store($ser:collection, "test-xsl.xml", $ser:test-xsl),
-    xmldb:store($ser:collection, "test.xsl", $ser:xsl)
+    xmldb:store($ser:collection, "test.xsl", $ser:xsl),
+    xmldb:store($ser:collection, "test-with-doctype.xml", $ser:test-xml-with-doctype)
 };
 
 declare
@@ -701,6 +704,22 @@ function ser:adaptive-xs-strings-map-params() {
         ser:adaptive-map-params($input, ",")
 };
 
+declare
+    %test:assertXPath("contains($result, '-//OASIS//DTD DITA BookMap//EN') and contains($result, 'bookmap.dtd')")
+function ser:exist-output-doctype-true() {
+    let $doc := doc($ser:collection || "/test-with-doctype.xml")
+    return
+        fn:serialize($doc, map { xs:QName("exist:output-doctype"): fn:true() })
+};
+
+declare
+    %test:assertXPath("not(contains($result, '-//OASIS//DTD DITA BookMap//EN')) and not(contains($result, 'bookmap.dtd'))")
+function ser:exist-output-doctype-false() {
+    let $doc := doc($ser:collection || "/test-with-doctype.xml")
+    return
+        fn:serialize($doc, map { xs:QName("exist:output-doctype"): fn:false() })
+};
+
 declare
     %test:assertXPath("contains($result, 'include')")
 function ser:exist-expand-xinclude-false() {