[fix] improve FunctionSignature.equals

fixes #5685

Erroneous comparison of signatures of anonymous functions lead to
wrong tail call optimizations that lead to an NPE further down the call stack.

Author: line-o

exist-core/src/main/java/org/exist/xquery/FunctionSignature.java

@@ -262,16 +262,20 @@ public boolean equals(final Object obj) {
         if(obj == null || !(obj instanceof FunctionSignature)) {
             return false;
         }
-        
-        final FunctionSignature other = (FunctionSignature)obj;
-        if(name == null) {
-            if(other.name != null) {
-                return false;
-            }    
-            return getArgumentCount() == other.getArgumentCount();
+        // quick comparison by object identity
+        if (this == obj) { return true; }
+
+        // anonymous functions cannot be compared by name and argument count
+        final FunctionSignature other = (FunctionSignature) obj;
+        if (
+                name == null || other.name == null ||
+                name.getLocalPart().equals("") ||
+                other.name.getLocalPart().equals("")
+        ) {
+            return false;
         }
-        
-        if(name.equals(other.name)) {
+
+        if (name.equals(other.name)) {
             return getArgumentCount() == other.getArgumentCount();
         }
 

exist-core/src/test/xquery/maps/maps.xqm

@@ -49,6 +49,16 @@ declare variable $mt:integerKeys := map {
     7 : "Saturday"
 };
 
+declare variable $mt:places := map {
+    "Scotland": map {
+        "Highlands": map {
+            "Inverness": 1,
+            "Fort William": 1
+        },
+        "Lowlands": map { "Glasgow": 1 }
+    }
+};
+
 declare variable $mt:mapOfSequences := map {0: (), 1 : ("One", "Two") };
 
 declare
@@ -720,7 +730,7 @@ function mt:single-entry-map() {
         map:for-each($map, function($k, $v) { $k })
 };
 
-declare 
+declare
     %test:assertEquals(5)
 function mt:qname() {
     let $a := 1
@@ -989,3 +999,29 @@ function mt:map-merge-2-empty-options-map() {
     let $actual := map:merge($maps, map {})
     return $expected?Su eq $actual?Su
 };
+
+(: test for issue https://github.com/eXist-db/exist/issues/5685 :)
+declare
+    %test:assertEquals("<ul><li>Scotland<ul><li>Highlands<ul><li>Fort William</li><li>Inverness</li></ul></li><li>Lowlands<ul><li>Glasgow</li></ul></li></ul></li></ul>")
+function mt:nested-map-for-each() {
+    <ul>{
+        map:for-each($mt:places, function($country-key, $region-map) {
+            <li>{
+                $country-key,
+                <ul>{
+                    map:for-each($region-map, function($region-key, $town-map) {
+                        <li>{
+                            $region-key,
+                            <ul>{
+                                map:for-each($town-map, function($town-key, $town-value) {
+                                    <li>{ $town-key }</li>
+                                })
+                            }</ul>
+                        }</li>
+                    })
+                }</ul>
+            }</li>
+        })
+    }</ul>
+    => serialize(map{'indent':false()})
+};