[refactor] Address code-review from @reinhapa

adamretter · adamretter · commit c3e4c1e964eb · 2023-05-10T10:46:30.000+02:00
diff --git a/exist-core/src/main/java/org/exist/repo/ClasspathHelper.java b/exist-core/src/main/java/org/exist/repo/ClasspathHelper.java
@@ -177,10 +177,10 @@ private static void scanPackageDir(Package pkg, Classpath classpath, Path module
                         }
                         p = p.normalize().toAbsolutePath();
 
-                        if (!Files.exists(p)) {
-                            LOG.warn("Unable to add '" + p + "' to the classpath for EXPath package: " + pkg.getName() + ", as the file does not exist!");
-                        } else {
+                        if (Files.exists(p)) {
                             classpath.addComponent(p.toString());
+                        } else {
+                            LOG.warn("Unable to add '" + p + "' to the classpath for EXPath package: " + pkg.getName() + ", as the file does not exist!");
                         }
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -177,10 +177,10 @@ private static void scanPackageDir(Package pkg, Classpath classpath, Path module`
`177`	`177`	`}`
`178`	`178`	`p = p.normalize().toAbsolutePath();`
`179`	`179`
`180`		`- if (!Files.exists(p)) {`
`181`		`- LOG.warn("Unable to add '" + p + "' to the classpath for EXPath package: " + pkg.getName() + ", as the file does not exist!");`
`182`		`- } else {`
	`180`	`+ if (Files.exists(p)) {`
`183`	`181`	`classpath.addComponent(p.toString());`
	`182`	`+ } else {`
	`183`	`+ LOG.warn("Unable to add '" + p + "' to the classpath for EXPath package: " + pkg.getName() + ", as the file does not exist!");`
`184`	`184`	`}`
`185`	`185`	`}`
`186`	`186`	`}`