[bugfix] Fix serialization item separators for nodes.

Author: chris-evolvedbinary

exist-core/src/main/java/org/exist/xquery/functions/fn/FunSerialize.java

@@ -148,7 +148,11 @@ public static Sequence normalize(final Expression callingExpr, final XQueryConte
                 if (next.getType() == Type.ATTRIBUTE || next.getType() == Type.NAMESPACE || next.getType() == Type.FUNCTION_REFERENCE)
                     {throw new XPathException(callingExpr, FnModule.SENR0001,
                         "It is an error if an item in the sequence to serialize is an attribute node or a namespace node.");}
-                temp.add(next);
+                if (itemSeparator != null && itemSeparator.length() > 0 && !temp.isEmpty()) {
+                    temp.add(new StringValue(itemSeparator + next.getStringValue()));
+                } else {
+                    temp.add(next);
+                }
             } else {
                 // atomic value
                 Item last = null;

exist-core/src/test/xquery/xquery3/serialize.xql

@@ -802,3 +802,47 @@ function ser:item-separator-adaptive-method() {
     let $data := (1, 2)
     return ser:serialize-with-item-separator($data, "adaptive")
 };
+
+declare
+    %test:assertEquals("1|2|3|4|5|6|7|8|9|10")
+function ser:serialize-xml-033() {
+    let $params :=
+        <output:serialization-parameters xmlns:output="http://www.w3.org/2010/xslt-xquery-serialization">
+            <output:method value="xml"/>
+            <output:item-separator value="|"/>
+        </output:serialization-parameters>
+    return serialize(1 to 10, $params)
+};
+
+declare
+    %test:assertEquals("1==2==3==4")
+function ser:serialize-xml-034() {
+    let $params :=
+        <output:serialization-parameters xmlns:output="http://www.w3.org/2010/xslt-xquery-serialization">
+            <output:method value="xml"/>
+            <output:omit-xml-declaration value="yes"/>
+            <output:item-separator value="=="/>
+        </output:serialization-parameters>
+    return serialize(1 to 4, $params)
+};
+
+declare
+    %test:assertEquals("1|2|3|4|5|6|7|8|9|10")
+function ser:serialize-xml-133() {
+    let $params := map {
+        "method" : "xml",
+        "item-separator" : "|"
+    }
+    return serialize(1 to 10, $params)
+};
+
+declare
+    %test:assertEquals("1==2==3==4")
+function ser:serialize-xml-134() {
+    let $params := map {
+        "method" : "xml",
+        "omit-xml-declaration" : true(),
+        "item-separator" : "=="
+    }
+    return serialize((1 to 4)!text{.}, $params)
+};