Skip to content

Commit e8ced07

Browse files
committed
[ignore] TODOs in line comments
1 parent 83291a1 commit e8ced07

File tree

1 file changed

+10
-24
lines changed

1 file changed

+10
-24
lines changed

exist-core/src/test/java/org/exist/xquery/FunctionTypeInElementContentTest.java

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,7 @@ public void arrayLiteral() throws XMLDBException {
4646
assertCompilationSuccess(query);
4747
}
4848

49-
/**
50-
* TODO: remove empty sequence after https://github.com/eXist-db/exist/issues/3472 is fixed
51-
*/
49+
// TODO: array content could be removed after https://github.com/eXist-db/exist/issues/3472 is fixed
5250
@Test
5351
public void arrayConstructor() throws XMLDBException {
5452
final String query = "element test { array { () } }";
@@ -68,9 +66,7 @@ public void partialBuiltIn() throws XMLDBException {
6866
assertCompilationError(query, error);
6967
}
7068

71-
/**
72-
* TODO: Investigate does still throw without location info
73-
*/
69+
// TODO: Investigate does still throw without location info
7470
@Ignore
7571
@Test
7672
public void functionReference() throws XMLDBException {
@@ -79,9 +75,7 @@ public void functionReference() throws XMLDBException {
7975
assertCompilationError(query, error);
8076
}
8177

82-
/**
83-
* Does not throw at compile time
84-
*/
78+
// Does not throw at compile time
8579
@Ignore
8680
@Test
8781
public void functionVariable() throws XMLDBException {
@@ -90,9 +84,6 @@ public void functionVariable() throws XMLDBException {
9084
assertCompilationError(query, error);
9185
}
9286

93-
/**
94-
* TODO: remove empty sequence after https://github.com/eXist-db/exist/issues/3551 is fixed
95-
*/
9687
@Test
9788
public void userDefinedFunction() throws XMLDBException {
9889
final String query = "element test { function () { () } }";
@@ -120,33 +111,28 @@ public void sequenceOfMaps() throws XMLDBException {
120111
}
121112

122113
/**
123-
* there is an edge case which would evaluate to empty sequence
124-
* but should arguably still throw
125-
* Does still throw without location info
126-
* TODO: add (sub-expression) location
114+
* This is an edge case, which would evaluate to empty sequence
115+
* but should arguably still throw.
127116
*/
117+
// TODO: add (sub-expression) location
128118
@Test
129119
public void sequenceOfMapsEdgeCase() throws XMLDBException {
130120
final String query = "element test { (map {})[2] }";
131121
final String error = "err:XQTY0105 Function types are not allowed in element content. Got map(*) [source: element test { (map {})[2] }]";
132122
assertCompilationError(query, error);
133123
}
134124

135-
/**
136-
* -- no error is thrown at compile time
137-
* TODO: add (sub-expression) location
138-
*/
125+
// TODO: add (sub-expression) location
126+
// TODO: this could throw at compile time
139127
@Test
140128
public void ArrayOfMaps() throws XMLDBException {
141129
final String query = "element test { [map {}] }";
142130
final String error = "An exception occurred during query execution: err:XQTY0105 Function types are not allowed in element content. Got map(*) [source: element test { [map{}] }]";
143131
assertCompilationError(query, error);
144132
};
145133

146-
/**
147-
* This could throw at compile time, but does not
148-
* TODO: add (sub-expression) location
149-
*/
134+
// TODO: add (sub-expression) location
135+
// TODO: This should throw at compile time, but does not
150136
@Ignore
151137
@Test
152138
public void mapConstructorInSubExpression() throws XMLDBException {

0 commit comments

Comments
 (0)