[refactor] Revise mechanism to get new class instance using reflection.

Author: dizzzz

extensions/indexes/lucene/src/main/java/org/exist/indexing/lucene/AnalyzerConfig.java

@@ -25,6 +25,7 @@
 import java.io.Serial;
 import java.lang.invoke.*;
 import java.lang.reflect.Field;
+import java.lang.reflect.InvocationTargetException;
 import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.List;
@@ -317,11 +318,11 @@ static KeyTypedValue<?> getConstructorParameter(final Element param) throws Para
                     final Class<?> fieldClazz = Class.forName(clazzName);
                     final Field field = fieldClazz.getField(fieldName);
                     field.setAccessible(true);
-                    final Object fValue = field.get(fieldClazz.newInstance());
+                    final Object fValue = field.get(fieldClazz.getDeclaredConstructor().newInstance());
                     yield new KeyTypedValue<>(name, fValue, Object.class);
 
                 } catch (final NoSuchFieldException | ClassNotFoundException | InstantiationException |
-                               IllegalAccessException reflectiveOperationException) {
+                               IllegalAccessException | NoSuchMethodException | InvocationTargetException reflectiveOperationException) {
                     throw new ParameterException(reflectiveOperationException.getMessage(), reflectiveOperationException);
                 }
             }

extensions/indexes/range/src/main/java/org/exist/indexing/range/RangeIndexConfigElement.java

@@ -38,6 +38,7 @@
 
 import javax.xml.datatype.XMLGregorianCalendar;
 import java.io.IOException;
+import java.lang.reflect.InvocationTargetException;
 import java.util.Map;
 
 import static org.exist.indexing.lucene.LuceneIndexConfig.MATCH_ATTR;
@@ -108,20 +109,20 @@ public RangeIndexConfigElement(Element node, Map<String, String> namespaces) thr
         if (!caseStr.isEmpty()) {
             caseSensitive = "yes".equalsIgnoreCase(caseStr);
         }
-        String custom = node.getAttribute("converter");
+        final String custom = node.getAttribute("converter");
         if (!custom.isEmpty()) {
             try {
-                Class customClass = Class.forName(custom);
-                typeConverter = (org.exist.indexing.range.conversion.TypeConverter) customClass.newInstance();
+                final Class<?> customClass = Class.forName(custom);
+                typeConverter = (org.exist.indexing.range.conversion.TypeConverter) customClass.getDeclaredConstructor().newInstance();
             } catch (ClassNotFoundException e) {
                 RangeIndex.LOG.warn("Class for custom-type not found: {}", custom);
-            } catch (InstantiationException | IllegalAccessException e) {
+            } catch (InstantiationException | IllegalAccessException | InvocationTargetException | NoSuchMethodException e) {
                 RangeIndex.LOG.warn("Failed to initialize custom-type: {}", custom, e);
             }
         }
     }
 
-    private void parseChildren(Node root) throws DatabaseConfigurationException {
+    private void parseChildren(final Node root) throws DatabaseConfigurationException {
         Node child = root.getFirstChild();
         while (child != null) {
             if (child.getNodeType() == Node.ELEMENT_NODE) {

extensions/indexes/range/src/main/java/org/exist/indexing/range/RangeIndexConfigField.java

@@ -28,6 +28,7 @@
 import org.exist.xquery.value.Type;
 import org.w3c.dom.Element;
 
+import java.lang.reflect.InvocationTargetException;
 import java.util.Map;
 
 /**
@@ -77,23 +78,23 @@ public RangeIndexConfigField(NodePath parentPath, Element elem, Map<String, Stri
                 throw new DatabaseConfigurationException("Invalid type declared for range index on " + match + ": " + typeStr);
             }
         }
-        String custom = elem.getAttribute("converter");
+        final String custom = elem.getAttribute("converter");
         if (!custom.isEmpty()) {
             try {
-                Class customClass = Class.forName(custom);
-                typeConverter = (org.exist.indexing.range.conversion.TypeConverter) customClass.newInstance();
+                final Class<?> customClass = Class.forName(custom);
+                typeConverter = (org.exist.indexing.range.conversion.TypeConverter) customClass.getDeclaredConstructor().newInstance();
             } catch (ClassNotFoundException e) {
                 RangeIndex.LOG.warn("Class for custom-type not found: {}", custom);
-            } catch (InstantiationException | IllegalAccessException e) {
+            } catch (InstantiationException | IllegalAccessException | NoSuchMethodException | InvocationTargetException e) {
                 RangeIndex.LOG.warn("Failed to initialize custom-type: {}", custom, e);
             }
         }
-        String nested = elem.getAttribute("nested");
+        final String nested = elem.getAttribute("nested");
         includeNested = (nested.isEmpty() || "yes".equalsIgnoreCase(nested));
         path.setIncludeDescendants(includeNested);
 
         // normalize whitespace if whitespace="normalize"
-        String whitespace = elem.getAttribute("whitespace");
+        final String whitespace = elem.getAttribute("whitespace");
         if (!whitespace.isEmpty()) {
             if ("trim".equalsIgnoreCase(whitespace)) {
                 wsTreatment = XMLString.SUPPRESS_BOTH;

extensions/modules/xslfo/src/main/java/org/exist/xquery/modules/xslfo/XSLFOModule.java

@@ -21,6 +21,7 @@
  */
 package org.exist.xquery.modules.xslfo;
 
+import java.lang.reflect.InvocationTargetException;
 import java.util.List;
 import java.util.Map;
 
@@ -88,8 +89,9 @@ public synchronized ProcessorAdapter getProcessorAdapter() {
 
                 try {
                     final Class<ProcessorAdapter> clazzAdapter = (Class<ProcessorAdapter>) Class.forName(processorAdapter);
-                    adapter = clazzAdapter.newInstance();
-                } catch (ClassNotFoundException | IllegalAccessException | InstantiationException cnfe) {
+                    adapter = clazzAdapter.getDeclaredConstructor().newInstance();
+                } catch (ClassNotFoundException | IllegalAccessException | InstantiationException |
+                         NoSuchMethodException | InvocationTargetException cnfe) {
                     logger.error("Unable to instantiate FO Processor Adapter:{}", cnfe.getMessage(), cnfe);
                 }
             }