[refactor] replace ArrayUtils.contains with Set.contains in FunBaseURI

Author: line-o

exist-core/src/main/java/org/exist/xquery/functions/fn/FunBaseURI.java

@@ -21,14 +21,14 @@
  */
 package org.exist.xquery.functions.fn;
 
-import org.apache.commons.lang3.ArrayUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.exist.xquery.*;
 import org.exist.xquery.value.*;
 import org.w3c.dom.Node;
 
 import java.net.URI;
 import java.net.URISyntaxException;
+import java.util.Set;
 
 import static org.exist.xquery.FunctionDSL.optParam;
 import static org.exist.xquery.FunctionDSL.returnsOpt;
@@ -67,6 +67,12 @@ public class FunBaseURI extends BasicFunction {
             FS_PARAM_NODE
     );
 
+    // Namespace node does not exist in xquery, hence left out of array.
+    private static final Set<Short> CANDIDATE_NODE_TYPES = Set.of(
+            Node.DOCUMENT_NODE, Node.ELEMENT_NODE, Node.ATTRIBUTE_NODE, Node.TEXT_NODE,
+            Node.COMMENT_NODE, Node.PROCESSING_INSTRUCTION_NODE
+    );
+
     public FunBaseURI(XQueryContext context, FunctionSignature signature) {
         super(context, signature);
     }
@@ -119,13 +125,8 @@ public Sequence eval(Sequence[] args, Sequence contextSequence) throws XPathExce
         final Node node = nodeValue.getNode();
         final short type = node.getNodeType();
 
-        // Namespace node does not exist in xquery, hence left out of array.
-        final short[] quickStops = {Node.ELEMENT_NODE, Node.ATTRIBUTE_NODE,
-                Node.PROCESSING_INSTRUCTION_NODE, Node.COMMENT_NODE, Node.TEXT_NODE,
-                Node.DOCUMENT_NODE};
-
         // Quick escape
-        if (!ArrayUtils.contains(quickStops, type)) {
+        if (!CANDIDATE_NODE_TYPES.contains(type)) {
             return Sequence.EMPTY_SEQUENCE;
         }