Tests need a refactor

[Embiggenerd]

A lot of the tests do not throw an error.

it('should return status 401', async () => { try { await chai.request(server).get(secret); } catch (error) { expect(error.status).to.equal(401); expect(error.response.text).to.equal('Unauthorized'); } });

should be:

it('Should return 401 without token in request', async () => { try { const result = await chai.request(server).get(secret); expect(result.status).to.equal(401); expect(result.response.text).to.equal('Unauthorized'); } catch (e) { throw new Error(e); } });

Because the error in the first example isn't thrown, it causes the assertion to fail, but the test still passes. Remember, try/catch causes the error to not be thrown unless you explicitly tell it to.

[eXtremeXR]

Hey @Embiggenerd, thanks for pointing that out. I wasn't the one who wrote the tests initially, but I'll try to fix that at some point. PRs are of course welcome if anyone wants to jump in.

[Embiggenerd]

I wouldn't mind actually, you helped me quite a bit. Will try to make some time soon.