Added test for operation id route parameter

Author: eadwinCode

ninja_extra/controllers/base.py

@@ -60,6 +60,17 @@ def get_route_functions(cls: Type) -> Iterable[RouteFunction]:
             yield method
 
 
+def get_all_controller_route_function(
+    controller: Union[Type["ControllerBase"], Type]
+) -> List[RouteFunction]:
+    route_functions: List[RouteFunction] = []
+    for item in dir(controller):
+        attr = getattr(controller, item)
+        if isinstance(attr, RouteFunction):
+            route_functions.append(attr)
+    return route_functions
+
+
 def compute_api_route_function(
     base_cls: Type, api_controller_instance: "APIController"
 ) -> None:

tests/test_route.py

@@ -25,7 +25,7 @@
     RouteFunction,
     RouteInvalidParameterException,
 )
-from ninja_extra.controllers.base import get_route_functions
+from ninja_extra.controllers.base import get_all_controller_route_function
 from ninja_extra.controllers.route.context import RouteContext
 from ninja_extra.exceptions import PermissionDenied
 from ninja_extra.permissions import AllowAny
@@ -77,6 +77,10 @@ def example_delete(self, ex_id: str):
     def example_list_create(self, ex_id: str):
         pass
 
+    @http_post("/example/operation-id", operation_id="example_post_operation_id")
+    def example_post_operation_id(self):
+        pass
+
 
 class TestControllerRoute:
     @pytest.mark.parametrize(
@@ -95,8 +99,10 @@ def test_api_controller_builds_accurate_operations_list(
         assert len(path_view.operations) == operation_count
 
     def test_controller_route_should_have_an_operation(self):
-        for route_func in get_route_functions(SomeTestController):
-            path_view = SomeTestController.get_path_operations().get(str(route_func))
+        for route_func in get_all_controller_route_function(SomeTestController):
+            path_view = SomeTestController.get_api_controller().path_operations.get(
+                str(route_func)
+            )
             operations = list(
                 filter(
                     lambda n: n.operation_id
@@ -105,6 +111,8 @@ def test_controller_route_should_have_an_operation(self):
                 )
             )
             assert len(operations) == 1
+            if str(route_func) == "/example/operation-id":
+                assert operations[0].operation_id == "example_post_operation_id"
             assert route_func.route.route_params.methods == operations[0].methods
 
     def test_controller_route_should_right_view_func_type(self):