fixed cov failing test

Author: eadwinCode

Makefile

@@ -10,31 +10,27 @@ clean: ## Removing cached python compiled files
 	find . -name \*~  | xargs  rm -fv
 	find . -name __pycache__  | xargs  rm -rfv
 
-install: ## Install dependencies
-	make clean
+install:clean ## Install dependencies
 	flit install --deps develop --symlink
 	pre-commit install -f
 
-lint: ## Run code linters
+lint:fmt ## Run code linters
 	make clean
 	black --check ninja_extra tests
 	ruff check ninja_extra tests
 	mypy ninja_extra
 
-fmt format: ## Run code formatters
-	make clean
+fmt format:clean ## Run code formatters
 	black ninja_extra tests
 	ruff check --fix ninja_extra tests
 
 
-test: ## Run tests
-	make clean
+test:clean ## Run tests
 	pytest .
 
-test-cov: ## Run tests with coverage
+test-cov:clean ## Run tests with coverage
 	make clean
 	pytest --cov=ninja_extra --cov-report term-missing tests
 
-doc-deploy: ## Run Deploy Documentation
-	make clean
+doc-deploy:clean ## Run Deploy Documentation
 	mkdocs gh-deploy --force

ninja_extra/controllers/base.py

@@ -166,8 +166,7 @@ def _get_permissions(self) -> Iterable[BasePermission]:
         """
         Instantiates and returns the list of permissions that this view requires.
         """
-        if not self.context:
-            return
+        assert self.context
 
         for permission_class in self.context.permission_classes:
             if isinstance(permission_class, (type, OperationHolderMixin)):

ninja_extra/exceptions.py

@@ -2,7 +2,7 @@
 DRF Exceptions
 """
 import math
-from typing import Any, Dict, List, Optional, Type, Union, cast, no_type_check
+from typing import Any, Dict, List, Optional, Type, Union, no_type_check
 
 from django.http import HttpRequest, HttpResponse, JsonResponse
 from django.utils.encoding import force_str
@@ -104,7 +104,7 @@ def __init__(
         code: Optional[Union[str, int]] = None,
     ) -> None:
         if detail is None:
-            detail = cast(str, self.default_detail)  # type:ignore[redundant-cast]
+            detail = self.default_detail
         if code is None:
             code = self.default_code
 
@@ -149,7 +149,7 @@ def __init__(
         code: Optional[Union[str, int]] = None,
     ):
         if detail is None:
-            detail = cast(str, self.default_detail)  # type:ignore[redundant-cast]
+            detail = self.default_detail
         if code is None:
             code = self.default_code
 

ninja_extra/signals.py

@@ -1,4 +1,4 @@
-from django.dispatch import Signal
+from django.dispatch import Signal  # pragma: no cover
 
-route_context_started = Signal()
-route_context_finished = Signal()
+route_context_started = Signal()  # pragma: no cover
+route_context_finished = Signal()  # pragma: no cover

pyproject.toml

@@ -62,7 +62,7 @@ test = [
     "pytest-cov",
     "pytest-django",
     "pytest-asyncio",
-    "mypy == 1.4.1",
+    "mypy == 1.5.1",
     "ruff ==0.0.275",
     "black == 23.7.0",
     "injector >= 0.19.0",