fixed failing test

Author: eadwinCode

ninja_extra/throttling/model.py

@@ -243,5 +243,6 @@ def get_cache_key(self, request: HttpRequest) -> Optional[str]:
             ident = request.user.pk
         else:
             ident = self.get_ident(request)
+            print("ident: ", ident)
 
         return self.cache_format % {"scope": self.scope, "ident": ident}

tests/test_controller.py

@@ -109,9 +109,7 @@ def example_with_id_response(self, organisation_id: int):
         assert _api_controller._prefix_has_route_param
 
         client = testing.TestClient(UsersController)
-        response = client.get(
-            "452",
-        )
+        response = client.get("452")
 
         assert response.json() == dict(organisation_id=452)
         assert [("", _api_controller)] == _api_controller.build_routers()
@@ -135,7 +133,7 @@ def test_controller_should_wrap_with_inject(self):
 
     def test_controller_should_have_path_operation_list(self):
         _api_controller = SomeControllerWithRoute.get_api_controller()
-        assert len(_api_controller._path_operations) == 4
+        assert len(_api_controller._path_operations) == 7
 
         route_function: RouteFunction = SomeControllerWithRoute.example
         path_view = _api_controller._path_operations.get(str(route_function))
@@ -292,7 +290,10 @@ def test_generic_controller_response_in_route_functions_works(self):
         response = client.get(f"/example/{_uuid_value}/generic")
 
         assert response.status_code == 201
-        assert Id[uuid.UUID](_uuid_value).convert_to_schema().dict() == response.json()
+        assert (
+            str(Id[uuid.UUID](_uuid_value).convert_to_schema().dict()["id"])
+            == response.json()["id"]
+        )
 
         ok_response = Ok[UserSchema](dict(name="John", age=56))
         result = SomeControllerWithRoute.example_with_ok_schema_response(

tests/test_throthling/test_decorator.py

@@ -16,7 +16,7 @@
     User6MinRateThrottle,
 )
 
-api = NinjaExtraAPI(urls_namespace="throttle_decorator")
+api = NinjaExtraAPI(urls_namespace="throttle_decorator_1")
 
 
 @api.get("/throttle_user_default")
@@ -239,16 +239,15 @@ def test_request_throttling_for_dynamic_throttling(self, monkeypatch):
         # for unauthenticated user
         with monkeypatch.context() as m:
             m.setattr(settings, "THROTTLE_RATES", {"dynamic_scope": "3/min"})
-            for dummy in range(3):
-                client.get("/dynamic_throttling_scope")
-            response = client.get("/dynamic_throttling_scope")
+            for dummy in range(4):
+                response = client.get("/dynamic_throttling_scope")
             assert response.status_code == 429
 
 
 @pytest.mark.skipif(django.VERSION < (3, 1), reason="requires django 3.1 or higher")
 @pytest.mark.asyncio
 async def test_async_throttling(monkeypatch):
-    api_async = NinjaExtraAPI(urls_namespace="decorator_async")
+    api_async = NinjaExtraAPI(urls_namespace="decorator_async_1")
 
     @api_async.get("/throttle_user_default_async")
     @throttle

tests/test_throthling/test_controller_throttling.py renamed to tests/test_throthling/test_throttle_controller.py

@@ -82,7 +82,6 @@ def test_controller_endpoints_throttling(self, endpoint, time_out, monkeypatch):
                 "THROTTLE_RATES",
                 {"dynamic_scope": "5/min", "user": "10/sec", "anon": "10/sec"},
             )
-            for dummy in range(time_out):
-                client.get(endpoint)
-            response = client.get(endpoint)
+            for dummy in range(time_out + 1):
+                response = client.get(endpoint)
             assert response.status_code == 429

tests/test_throthling/test_throttle_decorator_on_controllers.py

@@ -63,9 +63,8 @@ def test_request_throttling_for_dynamic_throttling(self, monkeypatch):
         # for unauthenticated user
         with monkeypatch.context() as m:
             m.setattr(settings, "THROTTLE_RATES", {"dynamic_scope": "3/min"})
-            for dummy in range(3):
+            for dummy in range(4):
                 client.get("/dynamic_throttling_scope")
-            response = client.get("/dynamic_throttling_scope")
             assert response.status_code == 429