Merge pull request #256 from eadwinCode/ninja_140

feat: Ninja 1.4.0 Support

Author: eadwinCode

ninja_extra/__init__.py

@@ -1,6 +1,6 @@
 """Django Ninja Extra - Class Based Utility and more for Django Ninja(Fast Django REST framework)"""
 
-__version__ = "0.22.6"
+__version__ = "0.22.8"
 
 import django
 

ninja_extra/operation.py

@@ -379,10 +379,10 @@ def add_operation(
         description: Optional[str] = None,
         tags: Optional[List[str]] = None,
         deprecated: Optional[bool] = None,
-        by_alias: bool = False,
-        exclude_unset: bool = False,
-        exclude_defaults: bool = False,
-        exclude_none: bool = False,
+        by_alias: Optional[bool] = None,
+        exclude_unset: Optional[bool] = None,
+        exclude_defaults: Optional[bool] = None,
+        exclude_none: Optional[bool] = None,
         url_name: Optional[str] = None,
         include_in_schema: bool = True,
         openapi_extra: Optional[Dict[str, Any]] = None,

ninja_extra/router.py

@@ -34,10 +34,10 @@ def add_api_operation(
         description: Optional[str] = None,
         tags: Optional[List[str]] = None,
         deprecated: Optional[bool] = None,
-        by_alias: bool = False,
-        exclude_unset: bool = False,
-        exclude_defaults: bool = False,
-        exclude_none: bool = False,
+        by_alias: Optional[bool] = None,
+        exclude_unset: Optional[bool] = None,
+        exclude_defaults: Optional[bool] = None,
+        exclude_none: Optional[bool] = None,
         url_name: Optional[str] = None,
         include_in_schema: bool = True,
         openapi_extra: Optional[Dict[str, Any]] = None,

pyproject.toml

@@ -42,7 +42,7 @@ classifiers = [
 
 requires = [
     "Django >= 2.2",
-    "django-ninja==1.3.0",
+    "django-ninja==1.4.0",
     "injector >= 0.19.0",
     "asgiref",
     "contextlib2"

tests/test_pagination.py

@@ -272,19 +272,28 @@ def test_case5(self):
         assert response["items"] == ITEMS[10:20]
 
         schema = api.get_openapi_schema()["paths"]["/api/items_5"]["get"]
-        # print(schema)
+        # print(schema["parameters"])
         assert schema["parameters"] == [
             {
                 "in": "query",
                 "name": "page",
+                "required": False,
                 "schema": {
-                    "title": "Page",
                     "default": 1,
                     "minimum": 1,
+                    "title": "Page",
                     "type": "integer",
                 },
+            },
+            {
+                "in": "query",
+                "name": "page_size",
                 "required": False,
-            }
+                "schema": {
+                    "anyOf": [{"minimum": 1, "type": "integer"}, {"type": "null"}],
+                    "title": "Page Size",
+                },
+            },
         ]
 
     def test_case6(self):