fixing mypy

Author: eadwinCode

mypy.ini

@@ -1,5 +1,5 @@
 [mypy]
-python_version = 3.6
+python_version = 3.8
 
 show_column_numbers = True
 
@@ -19,4 +19,4 @@ check_untyped_defs = True
 no_implicit_reexport = True
 
 [mypy-ninja_extra.compatible.*]
-ignore_errors = True
+ignore_errors = True

ninja_extra/controllers/response.py

@@ -61,7 +61,7 @@ class ControllerResponseMeta(type):
         pass
 
     class GenericControllerResponse(metaclass=ControllerResponseMeta):
-        def __new__(
+        def __new__(  # type:ignore[misc]
             cls: Type["ControllerResponse[T]"], *args: Any, **kwargs: Any
         ) -> "ControllerResponse[T]":
             if "_schema" not in cls.__dict__:
@@ -121,7 +121,7 @@ class Id(ControllerResponse[T]):
                 ==> 201, {id: "883a1a3d-7b10-458d-bccc-f9b7219342c9"}
     """
 
-    _schema = IdSchema[Any]  # type: ignore
+    _schema = IdSchema[Any]
     status_code: int = status.HTTP_201_CREATED
 
     def __init__(self, id: T) -> None:
@@ -154,7 +154,7 @@ class ASchema(BaseModel):
     """
 
     status_code: int = status.HTTP_200_OK
-    _schema = OkSchema[Any]  # type: ignore
+    _schema = OkSchema[Any]
 
     def __init__(self, message: Optional[Any] = None) -> None:
         super(Ok, self).__init__()
@@ -184,7 +184,7 @@ class ErrorSchema(BaseModel):
     """
 
     status_code: int = status.HTTP_200_OK
-    _schema = DetailSchema[Any]  # type: ignore
+    _schema = DetailSchema[Any]
 
     def __init__(
         self, message: Optional[Any] = None, status_code: int = status.HTTP_200_OK

ninja_extra/pagination.py

@@ -110,9 +110,9 @@ def get_paginated_response(self, *, base_url: str, page: Page) -> DictStrAny:
 
     @classmethod
     def get_response_schema(
-        cls, response_schema: Union[Schema, Type[Schema], Any]
+        cls, response_schema: Union[Type[Schema], Type[Any]]
     ) -> Any:
-        return PaginatedResponseSchema[response_schema]
+        return PaginatedResponseSchema[response_schema]  # type: ignore[valid-type]
 
     def get_next_link(self, url: str, page: Page) -> Optional[str]:
         if not page.has_next():

ninja_extra/schemas/response.py

@@ -1,5 +1,5 @@
 import sys
-from typing import Any, Dict, Generic, List, Optional, Type, TypeVar
+from typing import Any, Dict, Generic, List, Optional, Type, TypeVar, Union
 
 from ninja import Schema
 from ninja.constants import NOT_SET
@@ -34,7 +34,9 @@ class PaginatedResponseSchema(
 
     # Pydantic GenericModels has not way of identifying the _orig
     # __generic_model__ is more like a fix for that
-    PaginatedResponseSchema.__generic_model__ = PaginatedResponseSchema
+    PaginatedResponseSchema.__generic_model__ = (  # type:ignore[attr-defined]
+        PaginatedResponseSchema
+    )
 
     class NinjaPaginationResponseSchema(
         GenericModel, Generic[T], BaseNinjaResponseSchema
@@ -47,22 +49,24 @@ def validate_items(cls, value: Any) -> Any:
                 return list(value)
             return value
 
-    NinjaPaginationResponseSchema.__generic_model__ = NinjaPaginationResponseSchema
+    NinjaPaginationResponseSchema.__generic_model__ = (  # type:ignore[attr-defined]
+        NinjaPaginationResponseSchema
+    )
 
     class IdSchema(GenericModel, Generic[T], Schema):
         id: T
 
-    IdSchema.__generic_model__ = IdSchema
+    IdSchema.__generic_model__ = IdSchema  # type:ignore[attr-defined]
 
     class OkSchema(GenericModel, Generic[T], Schema):
-        detail: T = "Action was successful"
+        detail: Union[T, str] = "Action was successful"
 
-    OkSchema.__generic_model__ = OkSchema
+    OkSchema.__generic_model__ = OkSchema  # type:ignore[attr-defined]
 
     class DetailSchema(GenericModel, Generic[T], Schema):
         detail: T
 
-    DetailSchema.__generic_model__ = DetailSchema
+    DetailSchema.__generic_model__ = DetailSchema  # type:ignore[attr-defined]
 else:  # pragma: no cover
 
     class IdSchema(GenericType, generic_base_name="IdSchema"):