Merge pull request #144 from eadwinCode/fix_codestyle

fix: codestyle ci test

Author: eadwinCode

Makefile

@@ -10,6 +10,7 @@ clean: ## Removing cached python compiled files
 	find . -name \*~  | xargs  rm -fv
 	find . -name __pycache__  | xargs  rm -rfv
 	find . -name .ruff_cache  | xargs  rm -rfv
+	find . -name .mypy_cache  | xargs  rm -rfv
 
 install:clean ## Install dependencies
 	pip install -r requirements.txt

ninja_extra/controllers/base.py

@@ -87,7 +87,7 @@ def compute_api_route_function(
         api_controller_instance.add_controller_route_function(cls_route_function)
 
 
-class ControllerBase(ABC):
+class ControllerBase:
     """
     Abstract Controller Base implementation all Controller class should implement
 

ninja_extra/ordering.py

@@ -82,7 +82,7 @@ def ordering_queryset(
     ) -> Union[QuerySet, List]:
         ordering_ = self.get_ordering(items, ordering_input.ordering)
         if ordering_:
-            if isinstance(items, QuerySet):  # type:ignore
+            if isinstance(items, QuerySet):
                 return items.order_by(*ordering_)
             elif isinstance(items, list) and items:
 
@@ -124,7 +124,7 @@ def term_valid(term: str) -> bool:
     def get_valid_fields(self, items: Union[QuerySet, List]) -> List[str]:
         valid_fields: List[str] = []
         if self.ordering_fields == "__all__":
-            if isinstance(items, QuerySet):  # type:ignore
+            if isinstance(items, QuerySet):
                 valid_fields = self.get_all_valid_fields_from_queryset(items)
             elif isinstance(items, list):
                 valid_fields = self.get_all_valid_fields_from_list(items)

ninja_extra/searching.py

@@ -100,7 +100,7 @@ def searching_queryset(
         search_terms = self.get_search_terms(searching_input.search)
 
         if self.search_fields and search_terms:
-            if isinstance(items, QuerySet):  # type:ignore
+            if isinstance(items, QuerySet):
                 conditions_queryset = self.construct_conditions_for_queryset(
                     search_terms
                 )

tests/test_controller.py

@@ -84,7 +84,7 @@ def test_api_controller_as_decorator(self):
         api_controller_instance = controller_type.get_api_controller()
         assert api_controller_instance.prefix == ""
         assert api_controller_instance.tags == ["any"]
-        assert "abc" in SomeController.__module__
+        assert "ninja_extra.controllers.base" in SomeController.__module__
         assert "tests.test_controller" in Some2Controller.__module__
         assert Some2Controller.get_api_controller()