Skip to content

Commit 7c18f3d

Browse files
committed
fixed failing test and code linting
1 parent 1a2488a commit 7c18f3d

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

ninja_extra/operation.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,9 @@ def run(self, request: HttpRequest, **kw: Any) -> HttpResponseBase:
159159
values = self._get_values(request, kw, temporal_response)
160160
ctx.kwargs = values
161161
result = self.view_func(context=ctx, **values)
162-
_processed_results = self._result_to_response(request, result, temporal_response)
162+
_processed_results = self._result_to_response(
163+
request, result, temporal_response
164+
)
163165
return _processed_results
164166
except Exception as e:
165167
if isinstance(e, TypeError) and "required positional argument" in str(e):
@@ -275,10 +277,10 @@ async def run(self, request: HttpRequest, **kw: Any) -> HttpResponseBase: # typ
275277

276278

277279
class PathView(NinjaPathView):
278-
async def _async_view(self, request: HttpRequest, *args, **kwargs) -> HttpResponse: # type: ignore
280+
async def _async_view(self, request: HttpRequest, *args, **kwargs) -> HttpResponseBase: # type: ignore
279281
return await super(PathView, self)._async_view(request, *args, **kwargs)
280282

281-
def _sync_view(self, request: HttpRequest, *args, **kwargs) -> HttpResponse: # type: ignore
283+
def _sync_view(self, request: HttpRequest, *args, **kwargs) -> HttpResponseBase: # type: ignore
282284
return super(PathView, self)._sync_view(request, *args, **kwargs)
283285

284286
def add_operation(

tests/test_pagination.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def test_case1(self):
9494
"schema": {
9595
"title": "Limit",
9696
"default": 100,
97-
"exclusiveMinimum": 0,
97+
"minimum": 1,
9898
"type": "integer",
9999
},
100100
"required": False,
@@ -105,7 +105,7 @@ def test_case1(self):
105105
"schema": {
106106
"title": "Offset",
107107
"default": 0,
108-
"exclusiveMinimum": -1,
108+
"minimum": 0,
109109
"type": "integer",
110110
},
111111
"required": False,
@@ -132,7 +132,7 @@ def test_case2(self):
132132
"schema": {
133133
"title": "Limit",
134134
"default": 100,
135-
"exclusiveMinimum": 0,
135+
"minimum": 1,
136136
"type": "integer",
137137
},
138138
"required": False,
@@ -143,7 +143,7 @@ def test_case2(self):
143143
"schema": {
144144
"title": "Offset",
145145
"default": 0,
146-
"exclusiveMinimum": -1,
146+
"minimum": 0,
147147
"type": "integer",
148148
},
149149
"required": False,
@@ -213,7 +213,7 @@ def test_case5(self):
213213
"schema": {
214214
"title": "Page",
215215
"default": 1,
216-
"exclusiveMinimum": 0,
216+
"minimum": 1,
217217
"type": "integer",
218218
},
219219
"required": False,
@@ -291,7 +291,7 @@ async def test_case1(self):
291291
"schema": {
292292
"title": "Limit",
293293
"default": 100,
294-
"exclusiveMinimum": 0,
294+
"minimum": 1,
295295
"type": "integer",
296296
},
297297
"required": False,
@@ -302,7 +302,7 @@ async def test_case1(self):
302302
"schema": {
303303
"title": "Offset",
304304
"default": 0,
305-
"exclusiveMinimum": -1,
305+
"minimum": 0,
306306
"type": "integer",
307307
},
308308
"required": False,

0 commit comments

Comments
 (0)