removed deprecated warnings from route function

Author: eadwinCode

ninja_extra/controllers/route/route_functions.py

@@ -1,5 +1,4 @@
 import inspect
-import warnings
 from contextlib import contextmanager
 from functools import wraps
 from typing import TYPE_CHECKING, Any, Callable, Iterator, Optional, Tuple, cast
@@ -114,23 +113,6 @@ def as_view(
         as_view.get_route_function = lambda: self  # type:ignore
         return as_view
 
-    def _process_view_function_result(self, result: Any) -> Any:
-        """
-        This process any a returned value from view_func
-        and creates an api response if a result is ControllerResponseSchema
-
-        deprecated:: 0.21.5
-           This method is deprecated and will be removed in a future version.
-           The result processing should be handled by the response handlers.
-        """
-        warnings.warn(
-            "_process_view_function_result() is deprecated and will be removed in a future version. "
-            "The result processing should be handled by the response handlers.",
-            DeprecationWarning,
-            stacklevel=2,
-        )
-        return result
-
     def _get_controller_instance(self) -> "ControllerBase":
         from ninja_extra.controllers.base import ModelControllerBase
 
@@ -155,26 +137,6 @@ def _get_controller_instance(self) -> "ControllerBase":
 
         return controller_instance
 
-    def get_route_execution_context(
-        self, request: HttpRequest, *args: Any, **kwargs: Any
-    ) -> RouteContext:
-        warnings.warn(
-            "get_route_execution_context() is deprecated in favor of "
-            "ninja_extra.controllers.route.context.get_route_execution_context()",
-            DeprecationWarning,
-            stacklevel=2,
-        )
-
-        init_kwargs = {
-            "permission_classes": self.route.permissions
-            or self.api_controller.permission_classes,
-            "request": request,
-            "kwargs": kwargs,
-            "args": args,
-        }
-        context = RouteContext(**init_kwargs)  # type:ignore[arg-type]
-        return context
-
     @contextmanager
     def _prep_controller_route_execution(
         self, route_context: RouteContext, **kwargs: Any

tests/test_route.py

@@ -9,7 +9,6 @@
 from ninja_extra import api_controller, permissions, route
 from ninja_extra.constants import ROUTE_OBJECT
 from ninja_extra.context import (
-    RouteContext,
     get_route_execution_context,
 )
 from ninja_extra.controllers import (
@@ -20,7 +19,6 @@
 from ninja_extra.controllers.base import get_route_functions
 from ninja_extra.controllers.utils import get_api_controller
 from ninja_extra.exceptions import PermissionDenied
-from ninja_extra.permissions import AllowAny
 from ninja_extra.reflect import reflect
 
 from .schemas import UserSchema
@@ -320,22 +318,6 @@ def test_get_required_api_func_signature_return_filtered_signature(self):
         assert len(sig_parameter) == 1
         assert str(sig_parameter[0]).replace(" ", "") == "example_id:str"
 
-    def test_get_route_execution_context(self):
-        route.get("")(self.api_func)
-        route_object = reflect.get_metadata_or_raise_exception(
-            ROUTE_OBJECT, self.api_func
-        )
-        route_function = RouteFunction(route_object, Mock())
-        route_function.api_controller.permission_classes = [AllowAny]
-
-        route_context = route_function.get_route_execution_context(
-            anonymous_request, "arg1", "arg2", extra="extra"
-        )
-        assert isinstance(route_context, RouteContext)
-        expected_keywords = ("permission_classes", "request", "args", "kwargs")
-        for key in expected_keywords:
-            assert getattr(route_context, key)
-
     def test_get_controller_instance_return_controller_instance(
         self, get_route_function
     ):
@@ -348,19 +330,6 @@ def test_get_controller_instance_return_controller_instance(
         assert isinstance(controller_instance, SomeTestController)
         assert controller_instance.context is None
 
-    def test_process_view_function_result_return_tuple_or_input(
-        self, get_route_function
-    ):
-        route_function: RouteFunction = get_route_function(SomeTestController().example)
-        mock_result = {"detail": "Some Message", "status_code": 302}
-        response = route_function._process_view_function_result(mock_result)
-        assert response == mock_result
-
-        mock_result = {"status": 302, "message": "Some Message"}
-        response = route_function._process_view_function_result(mock_result)
-        assert not isinstance(response, tuple)
-        assert response == mock_result
-
 
 @pytest.mark.django_db
 class TestAPIControllerRoutePermission: