Merge pull request #42 from eadwinCode/response_type_schema_router

 Ninja Router Return Type as Response Schema

Author: eadwinCode

ninja_extra/router.py

@@ -1,4 +1,4 @@
-from typing import Any, Callable, Dict, List, Optional
+from typing import Any, Callable, Dict, List, Optional, get_type_hints
 
 from ninja.constants import NOT_SET
 from ninja.router import Router as NinjaRouter
@@ -40,6 +40,10 @@ def add_api_operation(
             self.path_operations[path] = path_view
         else:
             path_view = self.path_operations[path]
+
+        if response is NOT_SET:
+            response = get_type_hints(view_func).get("return") or NOT_SET
+
         path_view.add_operation(
             path=path,
             methods=methods,

tests/test_django_ninja_router.py

@@ -4,15 +4,29 @@
 from ninja_extra import NinjaExtraAPI, Router
 from ninja_extra.operation import PathView
 
+from .schemas import UserSchema
+
 api = NinjaExtraAPI(urls_namespace="ninja_router")
 
 
 @api.get("/endpoint")
 # view->api
-def global_op(request):
+def global_op(request) -> str:
     return "global"
 
 
+@api.get("/return_type_response")
+# view->api
+def return_type_response(request) -> UserSchema:
+    return dict(name="Eadwin", age=20)
+
+
+@api.get("/return_type_response-2")
+# view->api
+def return_type_response(request) -> UserSchema:
+    return UserSchema(name="Eadwin", age=20)
+
+
 first_router = Router()
 
 
@@ -105,3 +119,15 @@ def test_router_path_view():
     global_op_path_view = api.default_router.path_operations.get("/endpoint")
     assert router_op1_path_view
     assert isinstance(global_op_path_view, PathView)
+
+
+def test_return_response_type():
+    res = client.get("/return_type_response")
+    assert res.status_code == 200
+    data = res.json()
+    assert data == {"name": "Eadwin", "age": 20}
+
+    res = client.get("/return_type_response-2")
+    assert res.status_code == 200
+    data = res.json()
+    assert data == {"name": "Eadwin", "age": 20}