fixed failing tests

Author: eadwinCode

ninja_extra/controllers/route/route_functions.py

@@ -50,6 +50,7 @@ def __call__(
             *args,
             **kwargs,
         )
+        self.run_permission_check(context)
         return self.as_view(request, *args, route_context=context, **kwargs)
 
     def _get_required_api_func_signature(self) -> Tuple:
@@ -222,4 +223,5 @@ async def __call__(
             *args,
             **kwargs,
         )
+        await self.async_run_check_permissions(context)
         return await self.as_view(request, *args, route_context=context, **kwargs)

tests/test_permissions.py

@@ -263,7 +263,7 @@ async def permission_accept_type_and_instance_async(self):
 @pytest.mark.parametrize("route", ["permission/", "index/"])
 def test_permission_controller_instance(route):
     user = User.objects.create_user(
-        username="eadwin",
+        username="eadwin3",
         email="[email protected]",
         password="password",
         is_staff=True,
@@ -283,7 +283,7 @@ def test_permission_controller_instance(route):
 @pytest.mark.asyncio
 async def test_permission_controller_instance_async():
     user = await sync_to_async(User.objects.create_user)(
-        username="eadwin",
+        username="eadwin2",
         email="[email protected]",
         password="password",
         is_staff=True,

tests/test_route.py

@@ -351,7 +351,7 @@ def setup_method(self):
     def get_real_user_request(cls):
         _request = Mock()
         user = User.objects.create_user(
-            username="eadwin",
+            username="eadwin1",
             email="[email protected]",
             password="password",
             is_staff=True,

tests/test_throthling/test_models.py

@@ -125,7 +125,9 @@ def setup_method(self):
     def test_get_cache_key_returns_correct_value_for_authenticated_request(self):
         user = User.objects.create(username="test")
         self.request.user = user
-        assert self.throttle.get_cache_key(self.request) == "throttle_user_1"
+        assert self.throttle.get_cache_key(self.request) == "throttle_user_{}".format(
+            user.pk
+        )
 
     def test_get_cache_key_defaults_to_none(self):
         cache_key = self.throttle.get_cache_key(self.request)
@@ -165,7 +167,9 @@ def test_get_cache_key_returns_correct_value_for_authenticated_request(
             throttle = DynamicRateThrottle(scope="some_scope")
             user = User.objects.create(username="test")
             self.request.user = user
-            assert throttle.get_cache_key(self.request) == "throttle_some_scope_1"
+            assert throttle.get_cache_key(
+                self.request
+            ) == "throttle_some_scope_{}".format(user.pk)
 
     def test_get_cache_key_defaults_to_none(self, monkeypatch):
         with monkeypatch.context() as m: