Added support to register controllers through string imports

Author: eadwinCode

ninja_extra/main.py

@@ -1,10 +1,21 @@
 from importlib import import_module
-from typing import Any, Callable, Dict, List, Optional, Sequence, Tuple, Type, Union
+from typing import (
+    Any,
+    Callable,
+    Dict,
+    List,
+    Optional,
+    Sequence,
+    Tuple,
+    Type,
+    Union,
+    cast,
+)
 
 from django.core.exceptions import ImproperlyConfigured
 from django.http import HttpRequest, HttpResponse
 from django.urls import URLPattern, URLResolver
-from django.utils.module_loading import module_has_submodule
+from django.utils.module_loading import import_string, module_has_submodule
 from ninja import NinjaAPI
 from ninja.constants import NOT_SET
 from ninja.openapi.docs import DocsBase, Swagger
@@ -94,9 +105,14 @@ def urls(self) -> Tuple[List[Union[URLResolver, URLPattern]], str, str]:
         )
 
     def register_controllers(
-        self, *controllers: Union[Type[ControllerBase], Type]
+        self, *controllers: Union[Type[ControllerBase], Type, str]
     ) -> None:
         for controller in controllers:
+            if isinstance(controller, str):
+                controller = cast(
+                    Union[Type[ControllerBase], Type], import_string(controller)
+                )
+
             if not issubclass(controller, ControllerBase):
                 raise ImproperlyConfigured(
                     f"{controller.__class__.__name__} class is not a controller"

tests/test_controller.py

@@ -207,6 +207,15 @@ def test_controller_base_get_object_or_none_works(self):
                 assert isinstance(ex, exceptions.PermissionDenied)
 
 
+def test_controller_registration_through_string():
+    assert DisableAutoImportController.get_api_controller().registered is False
+
+    api = NinjaExtraAPI()
+    api.register_controllers("tests.test_controller.DisableAutoImportController")
+
+    assert DisableAutoImportController.get_api_controller().registered
+
+
 @pytest.mark.skipif(django.VERSION < (3, 1), reason="requires django 3.1 or higher")
 def test_async_controller():
     api_controller_decorator = api_controller(