Revert "fix: Ability To Disable Pagination In ModelControllers"

Author: eadwinCode

ninja_extra/controllers/model/schemas.py

@@ -41,9 +41,9 @@ class ModelPagination(PydanticModel):
     Model Controller Pagination Configuration
     """
 
-    klass: t.Optional[t.Type[PaginationBase]] = PageNumberPaginationExtra
+    klass: t.Type[PaginationBase] = PageNumberPaginationExtra
     paginator_kwargs: t.Optional[dict] = None
-    pagination_schema: t.Optional[t.Type[PydanticModel]] = PaginatedResponseSchema
+    pagination_schema: t.Type[PydanticModel] = PaginatedResponseSchema
     filter_schema: t.Optional[t.Type[FilterSchema]] = None
 
     @field_validator("pagination_schema", mode="before")

tests/test_model_controller/samples.py

@@ -65,20 +65,6 @@ class EventModelControllerDifferentPagination(ModelControllerBase):
     )
 
 
-@api_controller("/event-case-5")
-class EventModelControllerWithoutPagination(ModelControllerBase):
-    model_config = ModelConfig(
-        allowed_routes=[
-            "list",
-        ],
-        model=Event,
-        retrieve_schema=EventSchema,
-        pagination=ModelPagination(
-            klass=None,
-        ),
-    )
-
-
 @api_controller("/event-case-4")
 class EventModelControllerRetrieveAndList(ModelControllerBase):
     model_config = ModelConfig(

tests/test_model_controller/test_model_controller_schema.py

@@ -5,22 +5,9 @@
     EventModelControllerDifferentPagination,
     EventModelControllerRetrieveAndList,
     EventModelControllerWithDefinedSchema,
-    EventModelControllerWithoutPagination,
 )
 
 
-def test_event_model_open_api_schema_case_5():
-    api = NinjaExtraAPI()
-    api.register_controllers(EventModelControllerWithoutPagination)
-    schema = api.get_openapi_schema()
-
-    assert "get" in schema["paths"]["/api/event-case-5/"]
-    assert schema["paths"]["/api/event-case-5/"]["get"]["parameters"] == []
-    assert list(schema["components"]["schemas"].keys()) == [
-        "EventSchema",
-    ]
-
-
 def test_event_model_open_api_schema_case_3():
     api = NinjaExtraAPI()
     api.register_controllers(EventModelControllerDifferentPagination)