Skip to content

Commit d58fabc

Browse files
committed
fixed authentication run before permission execution
1 parent 7a8a0ea commit d58fabc

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

ninja_extra/operation.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -197,14 +197,14 @@ def run(self, request: HttpRequest, **kw: Any) -> HttpResponseBase:
197197
with self._prep_run(
198198
request, temporal_response=temporal_response, **kw
199199
) as ctx:
200-
route_function = self._get_route_function()
201-
if route_function:
202-
route_function.run_permission_check(ctx)
203-
204200
error = self._run_checks(request)
205201
if error:
206202
return error
207203

204+
route_function = self._get_route_function()
205+
if route_function:
206+
route_function.run_permission_check(ctx)
207+
208208
values = self._get_values(request, kw, temporal_response)
209209
ctx.kwargs.update(values)
210210
result = self.view_func(request, **values)
@@ -325,14 +325,14 @@ async def run(self, request: HttpRequest, **kw: Any) -> HttpResponseBase: # typ
325325
async with self._prep_run(
326326
request, temporal_response=temporal_response, **kw
327327
) as ctx:
328-
route_function = self._get_route_function()
329-
if route_function:
330-
await route_function.async_run_check_permissions(ctx) # type: ignore[attr-defined]
331-
332328
error = await self._run_checks(request)
333329
if error:
334330
return error
335331

332+
route_function = self._get_route_function()
333+
if route_function:
334+
await route_function.async_run_check_permissions(ctx) # type: ignore[attr-defined]
335+
336336
values = await self._get_values(request, kw, temporal_response) # type: ignore
337337
ctx.kwargs.update(values)
338338
result = await self.view_func(request, **values)

0 commit comments

Comments
 (0)