fixed exception logging and added tuple suppose for route response

Author: eadwinCode

ninja_extra/controllers/route/__init__.py

@@ -74,6 +74,8 @@ def __init__(
                     _response_computed.update({item.status_code: item.get_schema()})
                 elif isinstance(item, dict):
                     _response_computed.update(item)
+                elif isinstance(item, tuple):
+                    _response_computed.update({item[0]: item[1]})
             if not _response_computed:
                 raise RouteInvalidParameterException(
                     f"Invalid response configuration: {response}"

ninja_extra/operation.py

@@ -13,6 +13,7 @@
 
 from django.http import HttpRequest
 from django.http.response import HttpResponse, HttpResponseBase
+from django.utils.encoding import force_str
 from ninja.constants import NOT_SET
 from ninja.operation import (
     AsyncOperation as NinjaAsyncOperation,
@@ -21,6 +22,7 @@
 )
 from ninja.signature import is_async
 
+from ninja_extra.exceptions import APIException
 from ninja_extra.logger import request_logger
 from ninja_extra.signals import route_context_finished, route_context_started
 
@@ -47,11 +49,18 @@ def _log_action(
             msg = (
                 f'"{request.method.upper() if request.method else "METHOD NOT FOUND"} - '
                 f'{route_function.controller.__name__}[{self.view_func.__name__}] {request.path}" '
-                f"{duration if duration else str(ex)}"
+                f"{duration if duration else ''}"
             )
+            if ex:
+                msg += (
+                    f"{ex.status_code}"
+                    if isinstance(ex, APIException)
+                    else f"{force_str(ex.args)}"
+                )
+
             logger(msg, **kwargs)
-        except (Exception,):
-            pass
+        except (Exception,) as dd:
+            print(dd)
 
     def get_execution_context(
         self, request: HttpRequest, *args: Any, **kwargs: Any

tests/test_controller.py

@@ -7,7 +7,7 @@
 from ninja_extra import APIController, NinjaExtraAPI, route, router
 from ninja_extra.controllers import RouteFunction
 from ninja_extra.controllers.base import MissingRouterDecoratorException
-from ninja_extra.controllers.response import ControllerResponse, Detail, Id, Ok
+from ninja_extra.controllers.response import Detail, Id, Ok
 from ninja_extra.controllers.router import ControllerRouter
 from ninja_extra.permissions.common import AllowAny
 
@@ -100,25 +100,6 @@ def test_controller_route_definition_should_return_instance_route_definitions(se
 
 
 class TestAPIControllerResponse:
-    class CustomResponse(ControllerResponse):
-        status_code = 502
-
-        def __init__(self, email: str, name: str):
-            super().__init__()
-            self.email = email
-            self.name = name
-
-        class CustomSchema(Schema):
-            email: str
-            name: str
-
-        @classmethod
-        def get_schema(cls) -> Union[Schema, Type[Schema], Any]:
-            return cls.CustomSchema
-
-        def convert_to_schema(self) -> Any:
-            return self.CustomSchema.from_orm(self)
-
     ok_response = Ok("OK")
     id_response = Id("ID")
     detail_response = Detail(dict(errors=[dict(test="passed")]), status_code=302)
@@ -138,13 +119,6 @@ def test_controller_response(self):
             message=dict(errors=[dict(test="passed")])
         )
         assert self.id_response.status_code != Detail.status_code
-        # CustomResponse Response
-        custom_response = self.CustomResponse(email="some_email", name="some_name")
-        assert custom_response.get_schema() == self.CustomResponse.get_schema()
-        assert custom_response.convert_to_schema() == self.CustomResponse.get_schema()(
-            email="some_email", name="some_name"
-        )
-        assert custom_response.status_code == self.CustomResponse.status_code
 
     def test_controller_response_works(self):
         detail = Detail("5242", status_code=302)

tests/test_route.py

@@ -126,7 +126,7 @@ def example_list_create(self, ex_id: str):
         assert "Invalid response configuration" in str(ex)
 
     def test_route_response_parameters_computed_correctly(self):
-        unique_response = [Ok, Id, {302: Schema}]
+        unique_response = [Ok, Id, {302: Schema}, (401, Schema)]
         non_unique_response = [
             Ok,
             Id,
@@ -141,7 +141,7 @@ def example_unique_response(self, ex_id: str):
         def example_non_unique_response(self, ex_id: str):
             pass
 
-        assert len(example_unique_response.route.route_params.response) == 3
+        assert len(example_unique_response.route.route_params.response) == 4
         assert len(example_non_unique_response.route.route_params.response) == 2
 
     @pytest.mark.parametrize(