Discussion: decouple from `django-ninja-extra`

[brendan-morin]

Is the django-ninja-extra a critical dependency to getting this working? I tried following the function-based configs that don't use the ninja extra classes, and I see this error:

django.core.exceptions.ImproperlyConfigured: ninja_extra app is not installed. Did you forget register ninja_extra in INSTALLED_APPS

I'm wondering if this library may be too tightly coupled to ninja_extra, and would perhaps benefit from decoupling? For what it's worth. I think there's value in ninja_extra, and it's a great library. But it just seems like this library as a basic auth library for ninja should not need to know about or be co-installed with ninja_extra in order to be added to a ninja app.

If this was decoupled, I could see this easily being the standard solution for JWT in ninja.

[jvhuaiying]

I agree with your point, the reason this library hasn't been used in my project is just because of its coupling with "django-ninja-extra". By the way, if this library can't decouple from "django-ninja-extra", I'm not against using PYJWT

[brendan-morin]

@eadwinCode would love to hear your thoughts

[eadwinCode]

@brendan-morin Sorry for late response. Actually, when using the functional based solution for the ninja-jwt, you are not required to add ninja_extra to your installed apps. Thats a bug.
And I have looked at the source code and found the update that caused that. I will be fixing that today and make a new release afterwards

[eadwinCode]

@jvhuaiying By decouple, do you mean at project dependency level? like ninja-extra should not be installed when you install ninja-jwt?

[jvhuaiying]

@eadwinCode , thank you for developing this library — really appreciate it. As an independent developer, I would prefer to use as few external libraries as possible when achieving the same effect, so I still hope to be able to use the complete ninja-jwt without installing ninja-extra.

[eadwinCode]

@jvhuaiying, I understand what you mean now. The initial idea was to develop JWT for both ninja and ninja-extra. The problem was that during development, Ninja was lacking a lot of features at the time. So that was skipped.
But looking at the source code again today, it's still possible to decouple NinjaExtra from the package. The schema is already using ModelSchema from Ninja package which was initially ModelSchema from ninja-schema package. The only thing that need to be done is having the package define its own exceptions and exception handler.