chore: cleanups

Author: ealush

.eslintrc.js

@@ -46,7 +46,13 @@ module.exports = {
       rules: {
         '@typescript-eslint/no-explicit-any': 'off',
         '@typescript-eslint/explicit-module-boundary-types': 'off',
-        '@typescript-eslint/no-unused-vars': 'warn',
+        '@typescript-eslint/no-unused-vars': [
+          1,
+          {
+            argsIgnorePattern: '^_',
+            varsIgnorePattern: '^_',
+          },
+        ],
       },
     },
     {

.github/workflows/integration.yml

@@ -28,19 +28,19 @@ jobs:
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
+      - name: Setup .yarnrc.yml
+        run: |
+          yarn config set npmAuthToken $NPM_TOKEN || echo "No NPM_TOKEN found"
+          yarn config set npmAlwaysAuth true
+          echo //registry.npmjs.org/:_authToken=$NPM_TOKEN > ~/.npmrc || echo "No NPM_TOKEN found"
+        env:
+          NPM_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
       - name: Install
         run: yarn install --immutable
       - name: Test
         run: yarn test
       - name: Lint
         run: yarn lint
-      - name: Setup .yarnrc.yml
-        run: |
-          yarn config set npmAuthToken $NPM_TOKEN
-          yarn config set npmAlwaysAuth true
-          echo //registry.npmjs.org/:_authToken=$NPM_TOKEN > ~/.npmrc
-        env:
-          NPM_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
       - name: Release
         run: yarn release
         env:
@@ -54,4 +54,5 @@ jobs:
           PUBLIC_REPO_TOKEN: ${{secrets.PUBLIC_REPO_TOKEN}}
           EMAIL_ADDRESS: ${{secrets.EMAIL_ADDRESS}}
           GIT_NAME: ${{secrets.GIT_NAME}}
+          NPM_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
           npmAuthToken: ${{secrets.NPM_PUBLISH_TOKEN}}

.yarnrc.yml

@@ -4,10 +4,8 @@ nodeLinker: node-modules
 
 npmAlwaysAuth: true
 
-npmAuthToken: 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
-
 plugins:
   - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
-    spec: "@yarnpkg/plugin-interactive-tools"
+    spec: '@yarnpkg/plugin-interactive-tools'
 
 yarnPath: .yarn/releases/yarn-3.5.1.cjs

packages/vest/src/core/isolate/IsolateReconciler.ts

@@ -1,7 +1,7 @@
 import { TIsolate } from 'vestjs-runtime';
 
 export abstract class IsolateReconciler {
-  static match(currentNode: TIsolate, historyNode: TIsolate): boolean {
+  static match(_currentNode: TIsolate, _historyNode: TIsolate): boolean {
     return false;
   }
 

packages/vest/src/core/isolate/IsolateTest/IsolateTestReconciler.ts

@@ -1,9 +1,9 @@
-import { IsolateReconciler } from 'IsolateReconciler';
 import { Maybe, deferThrow, text } from 'vest-utils';
 import { IsolateInspector, Reconciler } from 'vestjs-runtime';
 import type { TIsolate } from 'vestjs-runtime';
 
 import { ErrorStrings } from 'ErrorStrings';
+import { IsolateReconciler } from 'IsolateReconciler';
 import type { TIsolateTest } from 'IsolateTest';
 import { VestTest } from 'VestTest';
 import cancelOverriddenPendingTest from 'cancelOverriddenPendingTest';

packages/vest/src/testUtils/partition.ts

@@ -1,7 +1,6 @@
 export default function partition<T>(
   array: T[],
-  // eslint-disable-next-line no-unused-vars
-  predicate: (value: T, index: number, array: T[]) => boolean
+  predicate: (value: T, _index: number, array: T[]) => boolean
 ): [T[], T[]] {
   return array.reduce(
     (partitions: [T[], T[]], value, number) => {

packages/vest/src/testUtils/suiteDummy.ts

@@ -90,14 +90,14 @@ export function untested(fields?: OneOrMoreOf<string>) {
 
 function createSuiteRunResult(
   fieldNames: Maybe<string[] | string>,
-  callback: (fieldName?: string) => void // eslint-disable-line no-unused-vars
+  callback: (_fieldName?: string) => void
 ) {
   return createSuite(fieldNames, callback)();
 }
 
 function createSuite(
   fieldNames: Maybe<string[] | string> = 'field_1',
-  callback: (fieldName?: string) => void // eslint-disable-line no-unused-vars
+  callback: (_fieldName?: string) => void
 ) {
   return create(() => {
     asArray(fieldNames).forEach(fieldName => callback(fieldName));

vx/scripts/release/steps/push_to_latest_branch.sh

@@ -21,6 +21,9 @@ git checkout -b $STABLE_BRANCH
 echo "Rebuilding yarn.lock"
 yarn
 
+echo "Cleaning up auth token"
+yarn config unset npmAuthToken
+
 echo "Commiting"
 git add -A
 git commit -m "$1" -m "$2"