Merge pull request #5 from eapolinario/copilot/improve-repo-quality

Fix shell script hygiene: shebang, pipefail, quoting, SC2155; add ShellCheck CI

Author: eapolinario

.github/workflows/shellcheck.yml

@@ -0,0 +1,23 @@
+name: Shell Lint
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  shellcheck:
+    name: ShellCheck
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+      - name: Run ShellCheck
+        uses: ludeeus/action-shellcheck@2.0.0
+        with:
+          check_together: 'yes'
+          severity: warning
+          ignore_paths: macos/zsh

macos/install.sh

@@ -1,8 +1,8 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
-set -eux # defensive bash programming.
+set -euo pipefail
 
-SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # Only run this script if both gpg *and* the private key are available
 if ! command -v gpg >/dev/null 2>&1; then
@@ -17,7 +17,7 @@ if ! gpg --list-keys 5C9B334784343A49 >/dev/null 2>&1; then
 fi
 
 CONFIG_HOME="${XDG_CONFIG_HOME:-${HOME}/.config}"
-echo $CONFIG_HOME
+echo "$CONFIG_HOME"
 
 ################
 # stow'd files #
@@ -27,16 +27,16 @@ echo $CONFIG_HOME
 stow -d "$SCRIPT_DIR" -vt ~ zsh
 stow -d "$SCRIPT_DIR/../common" -vt ~ authinfo
 
-mkdir -p ${CONFIG_HOME}/doom
-stow -d "$SCRIPT_DIR/../common" -vt ${CONFIG_HOME}/doom doom
+mkdir -p "${CONFIG_HOME}/doom"
+stow -d "$SCRIPT_DIR/../common" -vt "${CONFIG_HOME}/doom" doom
 
 for component in \
 		pip \
 		skhd \
 		tmux \
 		yabai; do
-	mkdir -p ${CONFIG_HOME}/${component}
-	stow -d "$SCRIPT_DIR" -vt ${CONFIG_HOME}/${component} ${component}
+	mkdir -p "${CONFIG_HOME}/${component}"
+	stow -d "$SCRIPT_DIR" -vt "${CONFIG_HOME}/${component}" "${component}"
 done
 
 #######################

omarchy/install.sh

@@ -2,7 +2,8 @@
 
 set -euo pipefail
 
-readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+readonly SCRIPT_DIR
 
 DRY_RUN=false
 declare -a STOW_FLAGS=()