Fix deadlock in attachInterruptParam (#953)

earlephilhower · web-flow · commit 6570c4856be9 · 2022-11-03T08:40:57.000-07:00
Thanks to @imwoo90 comment in #878 (comment)
diff --git a/cores/rp2040/wiring_private.cpp b/cores/rp2040/wiring_private.cpp
@@ -135,7 +135,7 @@ void attachInterruptParam(pin_size_t pin, voidFuncPtrParam callback, PinStatus m
     default:      return;  // ERROR
     }
     noInterrupts();
-    detachInterrupt(pin);
+    _detachInterruptInternal(pin);
     CBInfo cb(callback, param);
     _map.insert({pin, cb});
     gpio_set_irq_enabled_with_callback(pin, events, true, _gpioInterruptDispatcher);

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ void attachInterruptParam(pin_size_t pin, voidFuncPtrParam callback, PinStatus m`
`135`	`135`	`default: return; // ERROR`
`136`	`136`	`}`
`137`	`137`	`noInterrupts();`
`138`		`- detachInterrupt(pin);`
	`138`	`+ _detachInterruptInternal(pin);`
`139`	`139`	`CBInfo cb(callback, param);`
`140`	`140`	`_map.insert({pin, cb});`
`141`	`141`	`gpio_set_irq_enabled_with_callback(pin, events, true, _gpioInterruptDispatcher);`