Add compilation to CI (#155)

Stolen from ESP8266, modified to run basic sanity compiles on the core.

Fix warnings identified by the new checks.

Author: earlephilhower

.github/workflows/pull-request.yml

@@ -24,3 +24,39 @@ jobs:
       with:
         skip: ./pico-extras,./ArduinoCore-API,./libraries/SdFat,./libraries/Adafruit_TinyUSB_Arduino,./libraries/LittleFS/lib,./tools/pyserial,./pico-sdk,./.github,./docs/i2s.rst
         ignore_words_list: ser,DOUT
+
+
+  build-linux:
+    name: Build ${{ matrix.chunk }}
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        chunk: [0, 1, 2, 3, 4, 5, 6, 7]
+    steps:
+    - uses: actions/checkout@v2
+      with:
+        submodules: true
+    - uses: actions/setup-python@v2
+      with:
+        python-version: '3.x'
+    - name: Cache Linux toolchain
+      id: cache-linux
+      uses: actions/cache@v2
+      with:
+        path: ./tools/dist
+        key: ${{ runner.os }}-${{ hashFiles('package/package_pico_index.template.json', 'tests/common.sh') }}
+    - name: Build Sketches
+      env:
+        TRAVIS_BUILD_DIR: ${{ github.workspace }}
+        TRAVIS_TAG: ${{ github.ref }}
+        BUILD_PARITY: custom
+        mod: 8
+        rem: ${{ matrix.chunk }}
+      run: |
+        cd pico-sdk
+        git submodule update --init
+        cd ../pico-extras
+        git submodule update --init
+        cd ..
+        bash ./tests/build.sh
+

cores/rp2040/RP2040USB.cpp

@@ -161,7 +161,6 @@ uint8_t const * tud_hid_descriptor_report_cb(void)
 
 const uint8_t *tud_descriptor_configuration_cb(uint8_t index) {
     (void)index;
-    int len = 0;
     static uint8_t *usbd_desc_cfg;
 
     if (!usbd_desc_cfg) {
@@ -217,6 +216,7 @@ const uint8_t *tud_descriptor_configuration_cb(uint8_t index) {
 }
 
 const uint16_t *tud_descriptor_string_cb(uint8_t index, uint16_t langid) {
+    (void) langid;
     #define DESC_STR_MAX (20)
     static uint16_t desc_str[DESC_STR_MAX];
 

cores/rp2040/SerialUSB.cpp

@@ -125,7 +125,7 @@ size_t SerialUSB::write(const uint8_t *buf, size_t length) {
     static uint64_t last_avail_time;
     int i = 0;
     if (tud_cdc_connected()) {
-        for (int i = 0; i < length;) {
+        for (size_t i = 0; i < length;) {
             int n = length - i;
             int avail = tud_cdc_write_available();
             if (n > avail) n = avail;
@@ -173,12 +173,14 @@ static void CheckSerialReset() {
 }
 
 extern "C" void tud_cdc_line_state_cb(uint8_t itf, bool dtr, bool rts) {
+    (void) itf;
     _dtr = dtr ? true : false;
     _rts = rts ? true : false;
     CheckSerialReset();
 }
 
 extern "C" void tud_cdc_line_coding_cb(uint8_t itf, cdc_line_coding_t const* p_line_coding) {
+    (void) itf;
     _bps = p_line_coding->bit_rate;
     CheckSerialReset();
 }

cores/rp2040/SerialUSB.h

@@ -29,7 +29,7 @@ class SerialUSB : public HardwareSerial {
 public:
     SerialUSB() { }
     void begin(unsigned long baud = 115200) override;
-    void begin(unsigned long baud, uint16_t config) override { begin(baud); };
+    void begin(unsigned long baud, uint16_t config) override { (void) config; begin(baud); };
     void end() override;
 
     virtual int peek() override;

cores/rp2040/Tone.cpp

@@ -39,7 +39,7 @@ static PIOProgram _tonePgm(&tone_program);
 static std::map<pin_size_t, Tone *> _toneMap;
 
 void tone(uint8_t pin, unsigned int frequency, unsigned long duration) {
-    if ((pin < 0) || (pin > 29)) {
+    if (pin > 29) {
         DEBUGCORE("ERROR: Illegal pin in tone (%d)\n", pin);
         return;
     }
@@ -87,7 +87,7 @@ void tone(uint8_t pin, unsigned int frequency, unsigned long duration) {
 void noTone(uint8_t pin) {
     CoreMutex m(&_toneMutex);
 
-    if ((pin < 0) || (pin > 29) || !m) {
+    if ((pin > 29) || !m) {
         DEBUGCORE("ERROR: Illegal pin in tone (%d)\n", pin);
         return;
     }

cores/rp2040/posix.cpp

@@ -35,23 +35,34 @@ extern "C" int errno;
 
 extern "C" ssize_t _write(int fd, const void *buf, size_t count) {
 #if defined DEBUG_RP2040_PORT
+    (void) fd;
     return DEBUG_RP2040_PORT.write((const char *)buf, count);
 #else
+    (void) fd;
+    (void) buf;
+    (void) count;
     return 0;
 #endif
 }
 
 extern "C" int _chown (const char *path, uid_t owner, gid_t group) {
+    (void) path;
+    (void) owner;
+    (void) group;
     errno = ENOSYS;
     return -1;
 }
 
-extern "C" int _close (int fildes) {
+extern "C" int _close (int fd) {
+    (void) fd;
     errno = ENOSYS;
     return -1;
 }
 
 extern "C" int _execve (char  *name, char **argv, char **env) {
+    (void) name;
+    (void) argv;
+    (void) env;
     errno = ENOSYS;
     return -1;
 }
@@ -61,7 +72,9 @@ extern "C" int _fork (void) {
     return -1;
 }
 
-extern "C" int _fstat (int          fildes, struct stat *st) {
+extern "C" int _fstat (int fd, struct stat *st) {
+    (void) fd;
+    (void) st;
     errno = ENOSYS;
     return -1;
 }
@@ -74,6 +87,7 @@ extern "C" int _getpid (void) {
 static int64_t __timedelta_us = 0.0;
 
 extern "C" int _gettimeofday (struct timeval *tv, void *tz) {
+    (void) tz;
     uint64_t now_us = to_us_since_boot(get_absolute_time()) + __timedelta_us;
     if (tv) {
         tv->tv_sec = now_us / 1000000L;
@@ -83,6 +97,7 @@ extern "C" int _gettimeofday (struct timeval *tv, void *tz) {
 }
 
 extern "C" int settimeofday (const struct timeval *tv, const struct timezone *tz) {
+    (void) tz;
     uint64_t now_us = to_us_since_boot(get_absolute_time());
     if (tv) {
         uint64_t newnow_us;
@@ -94,62 +109,86 @@ extern "C" int settimeofday (const struct timeval *tv, const struct timezone *tz
 }
 
 extern "C" int _isatty (int file) {
+    (void) file;
     errno = ENOSYS;
     return 0;
 }
 
 extern "C" int _kill (int pid, int sig) {
+    (void) pid;
+    (void) sig;
     errno = ENOSYS;
     return -1;
 }
 
 extern "C" int _link (char *existing, char *newlink) {
+    (void) existing;
+    (void) newlink;
     errno = ENOSYS;
     return -1;
 }
 
 extern "C" int _lseek (int   file, int   ptr, int   dir) {
+    (void) file;
+    (void) ptr;
+    (void) dir;
     errno = ENOSYS;
     return -1;
 }
 
 extern "C" int _open (char *file, int   flags, int   mode) {
+    (void) file;
+    (void) flags;
+    (void) mode;
     errno = ENOSYS;
     return -1;
 }
 
 extern "C" int _read (int   file, char *ptr, int   len)
 {
+    (void) file;
+    (void) ptr;
+    (void) len;
 //    return Serial.read(ptr, len);
     return -1;
 }
 
 extern "C" int _readlink (const char *path, char *buf, size_t bufsize) {
+    (void) path;
+    (void) buf;
+    (void) bufsize;
     errno = ENOSYS;
     return -1;
 }
 
 extern "C" int _stat (const char  *file, struct stat *st) {
+    (void) file;
+    (void) st;
     errno = ENOSYS;
     return -1;
 }
 
 extern "C" int _symlink (const char *path1, const char *path2) {
+    (void) path1;
+    (void) path2;
     errno = ENOSYS;
     return -1;
 }
 
 extern "C" clock_t _times (struct tms *buf) {
+    (void) buf;
     errno = ENOSYS;
     return -1;
 }
 
 extern "C" int _unlink (char *name) {
+    (void) name;
     errno = ENOSYS;
     return -1;
 }
 
 extern "C" int _wait (int  *status) {
+    (void) status;
     errno = ENOSYS;
     return -1;
 }

cores/rp2040/wiring_analog.cpp

@@ -26,8 +26,7 @@
 #include <hardware/pll.h>
 #include <hardware/adc.h>
 
-static int32_t analogScale = 255;
-static uint32_t analogMap = 0;
+static uint32_t analogScale = 255;
 static uint16_t analogFreq = 1000;
 static bool pwmInitted = false;
 static bool adcInitted = false;
@@ -73,7 +72,7 @@ extern "C" void analogWriteResolution(int res) {
 extern "C" void analogWrite(pin_size_t pin, int val) {
     CoreMutex m(&_dacMutex);
 
-    if ((pin < 0) || (pin > 29) || !m) {
+    if ((pin > 29) || !m) {
         DEBUGCORE("ERROR: Illegal analogWrite pin (%d)\n", pin);
         return;
     }
@@ -89,7 +88,7 @@ extern "C" void analogWrite(pin_size_t pin, int val) {
 
     if (val < 0) {
         val = 0;
-    } else if (val > analogScale) {
+    } else if ((uint32_t)val > analogScale) {
         val = analogScale;
     }
 

cores/rp2040/wiring_digital.cpp

@@ -51,15 +51,15 @@ extern "C" void pinMode( pin_size_t ulPin, PinMode ulMode ) {
             return;
     }
 
-    if ((ulPin < 0) || (ulPin > 29)) {
+    if (ulPin > 29) {
         DEBUGCORE("ERROR: Illegal pin in pinMode (%d)\n", ulPin);
         return;
     }
     _pm[ulPin] = ulMode;
 }
 
 extern "C" void digitalWrite( pin_size_t ulPin, PinStatus ulVal ) {
-    if ((ulPin < 0) || (ulPin > 29)) {
+    if (ulPin > 29) {
         DEBUGCORE("ERROR: Illegal pin in pinMode (%d)\n", ulPin);
         return;
     }
@@ -81,10 +81,9 @@ extern "C" void digitalWrite( pin_size_t ulPin, PinStatus ulVal ) {
 }
 
 extern "C" PinStatus digitalRead( pin_size_t ulPin ) {
-    if ((ulPin < 0) || (ulPin > 29)) {
+    if (ulPin > 29) {
         DEBUGCORE("ERROR: Illegal pin in digitalRead (%d)\n", ulPin);
         return LOW;
     }
     return gpio_get(ulPin) ? HIGH : LOW;
 }
-

cores/rp2040/wiring_private.cpp

@@ -48,6 +48,7 @@ auto_init_mutex(_irqMutex);
 static std::map<pin_size_t, voidFuncPtr> _map;
 
 void _gpioInterruptDispatcher(uint gpio, uint32_t events) {
+    (void) events;
     // Only need to lock around the std::map check, not the whole IRQ callback
     voidFuncPtr cb = nullptr;
     {

cores/rp2040/wiring_pulse.cpp

@@ -27,7 +27,7 @@ extern "C" unsigned long pulseIn(uint8_t pin, uint8_t state, unsigned long timeo
     uint64_t start = time_us_64();
     uint64_t abort = start + timeout;
 
-    if ((pin < 0) || (pin > 29)) {
+    if (pin > 29) {
         DEBUGCORE("ERROR: Illegal pin in pulseIn (%d)\n", pin);
         return 0;
     }