Skip to content

Conversation

@Yveaux
Copy link
Contributor

@Yveaux Yveaux commented Sep 17, 2024

This change removes the default define of setting CFG_TUSB_DEBUG to 0 for rp2350 targets and allows a user to change the TUSB debug level at compile time.

This default is not present for rp2040 targets (https://github.com/earlephilhower/arduino-pico/blob/163b209d6c60733f110b02b9cb5f0b3c48970955/lib/rp2040/platform_def.txt)

And it defaults to 0 anyway:

#define CFG_TUSB_DEBUG 0
)

Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I just cut-n-pasted the entire Cmake define list for the rp2350 and I get many others are really defaults as well.

@earlephilhower earlephilhower merged commit 5fbda35 into earlephilhower:master Sep 17, 2024
20 checks passed
@Yveaux Yveaux deleted the Remove_CFG_TUSB_DEBUG_for_rp2350 branch September 17, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants