Remove stack protector check from runtime_init #3155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime_init will all the stack protector initializer from inside the function. Unfortunately that means that the sentinels for the runtime_init function will not be there and GCC will panic. Add no-stack-check attribute to the runtime_init function to avoid the check and re-enable stack smaeh protection. Fixes #3131
earlephilhower
force-pushed
the
nostk
branch
from
4804fa7 to
2638d8d
Compare
earlephilhower
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime_init will all the stack protector initializer from inside the function. Unfortunately that means that the sentinels for the runtime_init function will not be there and GCC will panic.
Add no-stack-check attribute to the runtime_init function to avoid the check and re-enable stack smaeh protection.
Fixes #3131