Skip to content

Commit d63718f

Browse files
authored
More OSs and architectures in Rust test matrix (#972)
1 parent 88756f2 commit d63718f

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

.github/workflows/rust-ci.yaml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
strategy:
4444
fail-fast: false
4545
matrix:
46-
os: [ubuntu-latest]
46+
os: [ubuntu-latest, ubuntu-24.04-arm, macos-13, macos-latest]
4747

4848
steps:
4949
- name: Checkout repository
@@ -52,10 +52,12 @@ jobs:
5252
ref: ${{ github.event.pull_request.head.sha }}
5353

5454
- name: Stand up docker services
55+
if: matrix.os == 'ubuntu-latest' || matrix.os == 'ubuntu-24.04-arm' || github.event_name == 'push'
5556
run: |
5657
docker compose up -d
5758
5859
- name: Wait for containers to be ready
60+
if: matrix.os == 'ubuntu-latest' || matrix.os == 'ubuntu-24.04-arm' || github.event_name == 'push'
5961
run: |
6062
for _ in {1..10}; do
6163
if curl --silent --fail http://minio:9000/minio/health/live; then
@@ -72,6 +74,7 @@ jobs:
7274
done
7375
7476
- name: Install Just
77+
if: matrix.os == 'ubuntu-latest' || matrix.os == 'ubuntu-24.04-arm' || github.event_name == 'push'
7578
run: sudo snap install --edge --classic just
7679

7780
- name: Install Rust toolchain
@@ -87,10 +90,11 @@ jobs:
8790
key: ${{ env.RUST_CHANNEL }}
8891

8992
- name: Install cargo-deny
93+
if: matrix.os == 'ubuntu-latest' || matrix.os == 'ubuntu-24.04-arm' || github.event_name == 'push'
9094
run: cargo install --locked cargo-deny
9195

9296
- name: Check
93-
if: matrix.os == 'ubuntu-latest' || github.event_name == 'push'
97+
if: matrix.os == 'ubuntu-latest' || matrix.os == 'ubuntu-24.04-arm' || github.event_name == 'push'
9498
env:
9599
R2_BUCKET: ${{ secrets.R2_BUCKET }}
96100
R2_ACCESS_KEY_ID: ${{ secrets.R2_ACCESS_KEY_ID }}
@@ -110,6 +114,11 @@ jobs:
110114
run: |
111115
just pre-commit
112116
117+
- name: Run unit tests only
118+
if: matrix.os != 'ubuntu-latest' && matrix.os != 'ubuntu-24.04-arm'
119+
run: |
120+
cargo test --lib
121+
113122
- name: Run integration tests against object stores
114123
if: github.event_name == 'cron'
115124
env:

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ repos:
1616
- id: ruff
1717
args: ["--fix", "--show-fixes", "icechunk-python/"]
1818
- repo: https://github.com/rhysd/actionlint
19-
rev: v1.7.4
19+
rev: v1.7.7
2020
hooks:
2121
- id: actionlint
2222
files: ".github/workflows/"

0 commit comments

Comments
 (0)