Allowing for clients that are not pointers to http.Client

[mariusor]

I am working on an ActivityPub library that has as a component a custom client that extends a default http.Client functionality with custom behaviour specific to ActivityPub.

I want to use this requests module for streamlining some of the request building and dispatching, as its fluent API would match pretty well with what I've been doing already.

One point where I stumbled is that I can't pass an instance of my custom client struct to the Client() method of the builder because it specifically expects a *http.Client.

I would be interested if this requirement can be relaxed to an interface { Do(*http.Request) (*http.Response, error) } as that seems to be the only call being made to it - unless I've missed something deeper in the module.

Also thank you for maintaining this @earthboundkid. I'm sad I've only recently stumbled upon it, as it could have saved me some headaches along the way. :)

[earthboundkid]

Would requests.DoerTransport work for your use case?

TBH, I'm still not sure if end users are supposed to be customizing Clients/Doers or Transports/RoundTrippers: golang/go#59266.

[mariusor]

I don't see requests.DoerTransport in pkg.go.dev but looking at the code I imagine you mean the interface type used here:

func DoerTransport(cl interface {
	Do(req *http.Request) (*http.Response, error)
}) Transport {
	return RoundTripFunc(cl.Do)
}

And I would like to pass a client to the requests builder that already has its own round tripper set-up, not build a round-tripper around a Doer that then gets used with a default http.Client. (I hope this makes sense).

---

Also your second link to the go discussion about Client/Doer vs. RoundTrippers does my brain in, I have also used the OAuth2.Transport as a model for appending Authorization mechanisms on requests before actually operating them. (And most recently for implementing a kludgy retry mechanism with multiple authorization options). Sigh. If this mechanism is decreed as non-idiomatic by the powers that be, I'm not sure in which direction to migrate... :(