Syncing position for observers via the CharacterMovement instead of the serialized predictive state

Author: Tshadow05

Runtime/Code/Player/Character/MovementSystem/CharacterAnimationSyncData.cs

@@ -9,6 +9,9 @@ public class CharacterAnimationSyncData {
     public Vector3 localVelocity = Vector3.zero;
     public Vector3 lookVector = Vector3.zero;
 
+    //Just for observers in predicted mode
+    public Vector3 position = Vector3.zero;
+
     // override object.Equals
     public override bool Equals(object obj) {
         CharacterAnimationSyncData data = (CharacterAnimationSyncData)obj;

Runtime/Code/Player/Character/MovementSystem/CharacterMovement.cs

@@ -850,6 +850,7 @@ private void Move(MoveInputData md) {
 			crouching = isCrouching,
 			localVelocity = currentLocalVelocity,
 			lookVector = lookVector,
+			position = transform.position,
 		});
 
 		if (didJump){
@@ -1134,17 +1135,20 @@ private void CommandSetFlying(bool flyModeEnabled) {
 
 	private void TrySetState(CharacterAnimationSyncData newStateData) {
 		bool isNewState = newStateData.state != this.stateSyncData.state;
-		bool isNewData = !newStateData.Equals(this.stateSyncData);
+		bool isNewData = !newStateData.Equals(this.stateSyncData) || (isServerAuth && stateSyncData.position != newStateData.position);
 
 		// If new value in the state
-		if (isNewData) {
+		if (isNewData ) {
 			this.stateSyncData = newStateData;
 			if(hasMovementAuth){
 				if(isClientOnly){
 					CommandSetStateData(newStateData);
-				} else if (isServerOnly){
-					RpcSetStateData(newStateData);
 				}
+				// Right now the visual state is controlled by the client only
+				// We may want server auth to update the state but that makes observers have even older version of the character
+				//  else if (isServerOnly ){
+				// 	RpcSetStateData(newStateData);
+				// }
 			}
 		}
 
@@ -1180,8 +1184,14 @@ private void ApplyNonLocalStateData(CharacterAnimationSyncData data) {
 		this.isGrounded = data.grounded;
 		this.isCrouching = data.crouching;
 		this.isSprinting = data.sprinting;
+
 		this.lookVector = data.lookVector;
 
+		//In server auth we don't sync position with the NetworkTransform so I am doing it here
+		if(this.IsObserver() && isServerAuth){
+			this.rigidbody.position = data.position;
+		}
+
 		if (oldState.state != data.state) {
 			stateChanged?.Invoke((int)data.state);
 		}

Runtime/Code/Player/Character/MovementSystem/ClientPrediction/AirshipPredictedController.cs

@@ -319,7 +319,7 @@ void ApplyState(T snapshotState){
     // serverTimestamp is the same value as serverState.timestamp
     protected void OnReceivedState(int serverTick, T serverState, bool forceReplay) {
         if(IsObserver()){
-            SnapTo(serverState);
+            //SnapTo(serverState);
             return;
         }
 

Runtime/Code/Player/Character/MovementSystem/ClientPrediction/CharacterMovement/AirshipPredictedCharacterMovement.cs

@@ -11,11 +11,12 @@
 public class AirshipPredictedCharacterMovement : AirshipPredictedController<CharacterMovementState> {
 
 #region PUBLIC 
-    [Header("References")]
+    public bool pauseOnReplay = false;
+
+    [Header("Character References")]
     public CharacterMovement movement;
 
     [Header("Variables")]
-    public bool pauseOnReplay = false;
 
 #endregion
 
@@ -183,7 +184,15 @@ public override void SnapTo(CharacterMovementState newState){
         if(showLogs){
             print("Snapping Movement To: " + newState.tick);
         }
-        movement.ForceToNewMoveState(newState);
+        if(IsObserver()){
+            //Observers just sync position. State and look vector are already synced by CharacterMovement
+            movement.rigidbody.position = newState.position;
+            movement.currentMoveState.position = newState.position;
+            movement.currentMoveState.velocity = newState.velocity;
+        }else{
+            //Sync this state into the character movement
+            movement.ForceToNewMoveState(newState);
+        }
     }
 
     public override void OnReplayStarted(AirshipPredictedState initialState, int historyIndex){