Remove string free for logging

Author: Sleitnick

Runtime/Code/Luau/LuauCoreCallbacks.cs

@@ -124,11 +124,10 @@ private static int LuauError(IntPtr thread, string err) {
     }
 
 #if UNITY_EDITOR
+    private static readonly Regex AnchorLinkPattern = new Regex(@"(\S+\.lua):(\d+)", RegexOptions.Compiled | RegexOptions.IgnoreCase);
     private static string InjectAnchorLinkToLuaScript(string logMessage) {
         // e.g. "path/to/my/script.lua:10: an error occurred"
-        var rx = new Regex(@"(\S+\.lua):(\d+)", RegexOptions.Compiled | RegexOptions.IgnoreCase);
-
-        return rx.Replace(logMessage, (m) => {
+        return AnchorLinkPattern.Replace(logMessage, (m) => {
             var scriptPath = m.Groups[1].Value;
             var line = m.Groups[2].Value;
 
@@ -140,14 +139,10 @@ private static string InjectAnchorLinkToLuaScript(string logMessage) {
 
     //when a lua thread prints something to console
     [AOT.MonoPInvokeCallback(typeof(LuauPlugin.PrintCallback))]
-    static void printf(LuauContext context, IntPtr thread, int style, int gameObjectId, IntPtr buffer, int length, IntPtr ptr) {
+    static void printf(LuauContext context, IntPtr thread, int style, int gameObjectId, IntPtr buffer, int length) {
         CurrentContext = context;
 
-        string res = LuauCore.PtrToStringUTF8(buffer, length);
-        if (res == null) {
-            LuauPlugin.LuauFreeString(ptr);
-            return;
-        }
+        var res = LuauCore.PtrToStringUTF8(buffer, length);
 
 #if UNITY_EDITOR
         if (style == 1 || style == 2) {
@@ -169,14 +164,11 @@ static void printf(LuauContext context, IntPtr thread, int style, int gameObject
             Debug.LogWarning(res, logContext);
         } else if (style == 2) {
             Debug.LogError(res, logContext);
-            //If its an error, the thread is suspended 
+            //If it's an error, the thread is suspended 
             ThreadDataManager.Error(thread);
-            //GetLuauDebugTrace(thread);
         } else {
             Debug.Log(res, logContext);
         }
-        
-        LuauPlugin.LuauFreeString(ptr);
     }
 
     [AOT.MonoPInvokeCallback(typeof(LuauPlugin.ToStringCallback))]

Runtime/Code/Luau/LuauPlugin.cs

@@ -10,7 +10,7 @@
 using Debug = UnityEngine.Debug;
 
 public static class LuauPlugin {
-	public delegate void PrintCallback(LuauContext context, IntPtr thread, int style, int gameObjectId, IntPtr buffer, int length, IntPtr ptr);
+	public delegate void PrintCallback(LuauContext context, IntPtr thread, int style, int gameObjectId, IntPtr buffer, int length);
 	public delegate int GetPropertyCallback(LuauContext context, IntPtr thread, int instanceId, IntPtr classNamePtr, int classNameSize, IntPtr propertyName, int propertyNameSize);
 	public delegate int SetPropertyCallback(LuauContext context, IntPtr thread, int instanceId, IntPtr classNamePtr, int classNameSize, IntPtr propertyName, int propertyNameSize, LuauCore.PODTYPE type, IntPtr propertyData, int propertySize);
 	public delegate int CallMethodCallback(LuauContext context, IntPtr thread, int instanceId, IntPtr className, int classNameSize, IntPtr methodName, int methodNameSize, int numParameters, IntPtr firstParameterType, IntPtr firstParameterData, IntPtr firstParameterSize, IntPtr shouldYield);
@@ -661,17 +661,6 @@ public static LuauContext LuauGetContextFromThread(IntPtr thread) {
 		ThreadSafetyCheck();
 		return GetContextFromThread(thread);
 	}
-
-#if UNITY_IPHONE
-    [DllImport("__Internal")]
-#else
-	[DllImport("LuauPlugin")]
-#endif
-	private static extern void FreeString(IntPtr cStringPtr);
-	public static void LuauFreeString(IntPtr cStringPtr) {
-		ThreadSafetyCheck();
-		FreeString(cStringPtr);
-	}
 
 #if UNITY_IPHONE
     [DllImport("__Internal")]