WIP handle case of no node.js

Author: Vorlias

Editor/ShellProcess.cs

@@ -1,4 +1,5 @@
-using System.Diagnostics;
+using System;
+using System.Diagnostics;
 using Debug = UnityEngine.Debug;
 
 namespace Editor {
@@ -42,6 +43,42 @@ public static ProcessStartInfo GetStartInfoForCommand(string workingDirectory, s
             };
             return procStartInfo;
         }
+
+        public static string FindExecutableOnPath(string executable) {
+#if UNITY_EDITOR_WIN
+            var proc = new Process();
+            var startInfo = GetShellStartInfoForCommand($"where {executable}", Environment.CurrentDirectory);
+            startInfo.RedirectStandardOutput = true;
+            proc.StartInfo = startInfo;
+            proc.Start();
+            var res = proc.StandardOutput.ReadToEnd().Split("\r\n")[0];
+            return res;
+#else
+            var proc = new Process();
+            var startInfo = GetShellStartInfoForCommand($"command -v {executable}", Environment.CurrentDirectory);
+            startInfo.RedirectStandardOutput = true;
+            proc.StartInfo = startInfo;
+            proc.Start();
+            var res = proc.StandardOutput.ReadToEnd().Split("\n")[0];
+            return res;
+#endif
+        }
+
+        public static string FindNodeBinPath() {
+#if UNITY_EDITOR_WIN
+            // Windows is ensured to be in PATH
+            return FindExecutableOnPath("node");
+#else
+            // We can check via PATH first -
+            var pathExecutable = FindExecutableOnPath("node");
+            if (pathExecutable != null) {
+                return pathExecutable;
+            }
+                
+            Debug.LogWarning("Node is not on your PATH");
+            return null;
+#endif
+        }
 
         /// <summary>
         /// Gets the operating system specific ProcessStartInfo for the given command

Editor/TypescriptServices/Compiler/TypescriptCompilationService.cs

@@ -32,6 +32,23 @@ namespace Airship.Editor {
         public static class TypescriptCompilationService {
             private const string TsCompilerService = "Typescript Compiler Service";
 
+            private static string _nodePath;
+            public static string NodePath {
+                get {
+                    if (_nodePath == null) {
+                        var executable = ShellProcess.FindNodeBinPath().Trim();
+                        if (executable != "") {
+                            _nodePath = Path.GetDirectoryName(executable);
+                            return _nodePath;
+                        }
+
+                        return null;
+                    }
+
+                    return _nodePath;
+                }   
+            }
+            
             /// <summary>
             /// True if the compiler is running in watch mode
             /// </summary>

Editor/TypescriptServices/TypescriptServices.cs

@@ -41,6 +41,13 @@ public static void OnLoad() {
 #endif
             // If a server or clone - ignore
             if (!IsValidEditor) return;
+
+            if (TypescriptCompilationService.NodePath == null) {
+                Debug.LogWarning("[TypescriptServices] Node.js could not be found on your path, please read https://docs.airship.gg/getting-started/installing-airship for how to set up Airship correctly.");
+                Debug.LogWarning("\tIf you already installed Node.js, restart Unity and Unity Hub and try again.");
+                return;
+            }
+            
             EditorApplication.delayCall += OnLoadDeferred;
 
             EditorApplication.playModeStateChanged += PlayModeStateChanged;