Skip to content

Commit d44c0d2

Browse files
committed
Editor fixes
1 parent f7a33c4 commit d44c0d2

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

Editor/AirshipComponentEditor.cs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public class ScriptBindingEditor : UnityEditor.Editor {
3131

3232
public void OnEnable() {
3333
var comp = (Component)serializedObject.targetObject;
34-
var metadata = serializedObject.FindProperty("m_metadata");
34+
var metadata = serializedObject.FindProperty("metadata");
3535
var metadataProperties = metadata.FindPropertyRelative("properties");
3636
for (var i = 0; i < metadataProperties.arraySize; i++) {
3737
var serializedProperty = metadataProperties.GetArrayElementAtIndex(i);
@@ -73,7 +73,7 @@ public override void OnInspectorGUI() {
7373
}
7474

7575
if (binding.script != null) {
76-
var metadata = serializedObject.FindProperty("m_metadata");
76+
var metadata = serializedObject.FindProperty("metadata");
7777
var metadataName = metadata.FindPropertyRelative("name");
7878
if (!string.IsNullOrEmpty(metadataName.stringValue)) {
7979
DrawBinaryFileMetadata(binding, metadata);
@@ -157,7 +157,7 @@ private void MatchReferenceArraySize(SerializedProperty targetArray, SerializedP
157157
}
158158

159159
private void CheckDefaults(AirshipComponent binding) {
160-
var metadata = serializedObject.FindProperty("m_metadata");
160+
var metadata = serializedObject.FindProperty("metadata");
161161

162162
var metadataProperties = metadata.FindPropertyRelative("properties");
163163
var originalMetadataProperties = binding.script.m_metadata.properties;
@@ -205,7 +205,7 @@ bool HaveTypesChanged() {
205205
private bool ShouldReconcile(AirshipComponent binding) {
206206
if (binding.metadata == null || binding.script.m_metadata == null) return false;
207207

208-
var metadata = serializedObject.FindProperty("m_metadata");
208+
var metadata = serializedObject.FindProperty("metadata");
209209

210210
var metadataProperties = metadata.FindPropertyRelative("properties");
211211
var originalMetadataProperties = binding.script.m_metadata?.properties;
@@ -285,10 +285,9 @@ private void DrawScriptBindingProperties(AirshipComponent binding) {
285285
EditorGUILayout.Space(5);
286286

287287
var script = binding.script;
288-
var scriptPath = serializedObject.FindProperty("m_fileFullPath");
289288
var content = new GUIContent {
290289
text = "Script",
291-
tooltip = scriptPath.stringValue,
290+
tooltip = script == null ? "" : script.m_path,
292291
};
293292

294293
if (script != null && (binding.metadata != null || Application.isPlaying)) {
@@ -298,7 +297,6 @@ private void DrawScriptBindingProperties(AirshipComponent binding) {
298297
var newScript = EditorGUILayout.ObjectField(content, script, typeof(AirshipScript), true);
299298
if (newScript != script) {
300299
binding.script = (AirshipScript)newScript;
301-
scriptPath.stringValue = newScript == null ? "" : ((AirshipScript)newScript).assetPath;
302300
serializedObject.ApplyModifiedProperties();
303301
}
304302

Runtime/Code/Luau/AirshipComponent.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class AirshipComponent : MonoBehaviour {
2222
private const bool ElevateToProtectedWithinCoreScene = true;
2323

2424
public static LuauScript.AwakeData QueuedAwakeData = null;
25-
public static Dictionary<int, string> ComponentIdToScriptName = new();
25+
public static readonly Dictionary<int, string> ComponentIdToScriptName = new();
2626
private static int _airshipComponentIdGen = 10000000;
2727
private static bool _validatedSceneInGameConfig = false;
2828

@@ -83,6 +83,11 @@ private void Awake() {
8383
QueuedAwakeData = null;
8484
}
8585

86+
if (script == null) {
87+
Debug.LogError($"No script assigned to AirshipComponent ({gameObject.name})", gameObject);
88+
return;
89+
}
90+
8691
ComponentIdToScriptName[_airshipComponentId] = string.Intern(script.name);
8792

8893
ScriptingEntryPoint.InvokeOnLuauStartup();

0 commit comments

Comments
 (0)