Skip to content

Commit ad19427

Browse files
committed
Be more careful with failed message
It is not given that the test output parsing code is the issue. There is no reasonable output if the test failed to start at all, e.g. due to syntax errors.
1 parent f73302c commit ad19427

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

easybuild/easyblocks/p/pytorch.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ def test_step(self):
539539
reason = f'Terminated with {signal}'
540540
except KeyError:
541541
# Not ended with signal, might have failed due to e.g. syntax errors
542-
reason = 'Did not run properly'
542+
reason = 'Undetected or did not run properly'
543543
failure_msgs.append(f'\t{suite_name} ({reason})')
544544
# Test suites not included in the catch-all regexp but counted. Should be empty.
545545
unexpected_test_suites = failed_test_suites - all_failed_test_suites
@@ -574,7 +574,7 @@ def test_step(self):
574574
for name_signal in sorted(parsed_test_result.terminated_suites.items()))
575575
elif len(failed_test_suites) < len(all_failed_test_suites):
576576
msg = ('Failing because not all failed tests could be determined. '
577-
'The test accounting in the PyTorch EasyBlock needs updating!\n'
577+
'Tests failed to start or the test accounting in the PyTorch EasyBlock needs updating!\n'
578578
'Missing: ' + ', '.join(sorted(all_failed_test_suites - failed_test_suites)))
579579
else:
580580
msg = ('Failing because there were unexpected failures detected: ' +

0 commit comments

Comments
 (0)