Skip to content

Commit 0f3f29d

Browse files
author
Alan O'Cais
committed
Also update docker container recipes
1 parent 30ac78d commit 0f3f29d

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

easybuild/tools/containers/docker.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@
4444
"""
4545

4646
DOCKER_INSTALL_EASYBUILD = """\
47-
RUN pip install -U pip setuptools && \\
48-
hash -r pip && \\
49-
pip install -U easybuild
47+
RUN pip3 install -U pip setuptools && \\
48+
hash -r pip3&& \\
49+
pip3 install -U easybuild
5050
5151
RUN mkdir /app && \\
5252
mkdir /scratch && \\
@@ -72,9 +72,12 @@
7272
CMD ["/bin/bash", "-l"]
7373
"""
7474

75-
DOCKER_UBUNTU1604_INSTALL_DEPS = """\
75+
DOCKER_UBUNTU2004_INSTALL_DEPS = """\
7676
RUN apt-get update && \\
77-
apt-get install -y python python-pip lmod curl wget
77+
apt-get install -y python3 python3-pip lmod curl wget git \\
78+
bzip2 gzip tar zip unzip xz-utils \\
79+
patch automake git debianutils \\
80+
g++ libdata-dump-perl libthread-queue-any-perl
7881
7982
RUN OS_DEPS='%(os_deps)s' && \\
8083
test -n "${OS_DEPS}" && \\
@@ -83,15 +86,18 @@
8386

8487
DOCKER_CENTOS7_INSTALL_DEPS = """\
8588
RUN yum install -y epel-release && \\
86-
yum install -y python python-pip Lmod curl wget git
89+
yum install -y python3 python3-pip Lmod curl wget git \\
90+
bzip2 gzip tar zip unzip xz \\
91+
patch makefile git which \\
92+
gcc-c++ perl-Data-Dumper perl-Thread-Queue
8793
8894
RUN OS_DEPS='%(os_deps)s' && \\
8995
test -n "${OS_DEPS}" && \\
9096
yum --skip-broken install -y "${OS_DEPS}" || true
9197
"""
9298

9399
DOCKER_OS_INSTALL_DEPS_TMPLS = {
94-
DOCKER_BASE_IMAGE_UBUNTU: DOCKER_UBUNTU1604_INSTALL_DEPS,
100+
DOCKER_BASE_IMAGE_UBUNTU: DOCKER_UBUNTU2004_INSTALL_DEPS,
95101
DOCKER_BASE_IMAGE_CENTOS: DOCKER_CENTOS7_INSTALL_DEPS,
96102
}
97103

test/framework/containers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ def test_end2end_dockerfile(self):
386386
base_args + ['--container-config=not-supported'],
387387
raise_error=True)
388388

389-
for cont_base in ['ubuntu:16.04', 'centos:7']:
389+
for cont_base in ['ubuntu:20.04', 'centos:7']:
390390
stdout, stderr = self.run_main(base_args + ['--container-config=%s' % cont_base])
391391
self.assertFalse(stderr)
392392
regexs = ["^== Dockerfile definition file created at %s/containers/Dockerfile.toy-0.0" % self.test_prefix]
@@ -406,10 +406,10 @@ def test_end2end_dockerfile(self):
406406
remove_file(os.path.join(self.test_prefix, 'containers', 'Dockerfile.toy-0.0'))
407407

408408
base_args.insert(1, os.path.join(test_ecs, 'g', 'GCC', 'GCC-4.9.2.eb'))
409-
self.run_main(base_args + ['--container-config=ubuntu:16.04'])
409+
self.run_main(base_args + ['--container-config=ubuntu:20.04'])
410410
def_file = read_file(os.path.join(self.test_prefix, 'containers', 'Dockerfile.toy-0.0'))
411411
regexs = [
412-
"FROM ubuntu:16.04",
412+
"FROM ubuntu:20.04",
413413
"eb toy-0.0.eb GCC-4.9.2.eb",
414414
"module load toy/0.0 GCC/4.9.2",
415415
]

0 commit comments

Comments
 (0)