Skip to content

Commit 0f4ddfa

Browse files
authored
Merge pull request #4347 from Flamefire/document-maj-ver-template
include major version (`*majver`) templates in auto-generated documentation
2 parents bbf0c71 + e759c92 commit 0f4ddfa

File tree

5 files changed

+12
-3
lines changed

5 files changed

+12
-3
lines changed

easybuild/framework/easyconfig/templates.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@
7777
('installdir', "Installation directory"),
7878
('start_dir', "Directory in which the build process begins"),
7979
]
80-
# software names for which to define <pref>ver and <pref>shortver templates
80+
# software names for which to define <pref>ver, <pref>majver and <pref>shortver templates
8181
TEMPLATE_SOFTWARE_VERSIONS = [
82-
# software name, prefix for *ver and *shortver
82+
# software name, prefix for *ver, *majver and *shortver
8383
('CUDA', 'cuda'),
8484
('CUDAcore', 'cuda'),
8585
('Java', 'java'),
@@ -427,6 +427,7 @@ def template_documentation():
427427
# step 2: add *ver/*shortver templates for software listed in TEMPLATE_SOFTWARE_VERSIONS
428428
doc.append("Template names/values for (short) software versions")
429429
for name, pref in TEMPLATE_SOFTWARE_VERSIONS:
430+
doc.append("%s%%(%smajver)s: major version for %s" % (indent_l1, pref, name))
430431
doc.append("%s%%(%sshortver)s: short version for %s (<major>.<minor>)" % (indent_l1, pref, name))
431432
doc.append("%s%%(%sver)s: full version for %s" % (indent_l1, pref, name))
432433

easybuild/tools/docs.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -440,6 +440,7 @@ def avail_easyconfig_templates_txt():
440440
# step 2: add SOFTWARE_VERSIONS
441441
doc.append('Template names/values for (short) software versions')
442442
for name, pref in TEMPLATE_SOFTWARE_VERSIONS:
443+
doc.append("%s%%(%smajver)s: major version for %s" % (INDENT_4SPACES, pref, name))
443444
doc.append("%s%%(%sshortver)s: short version for %s (<major>.<minor>)" % (INDENT_4SPACES, pref, name))
444445
doc.append("%s%%(%sver)s: full version for %s" % (INDENT_4SPACES, pref, name))
445446
doc.append('')
@@ -494,8 +495,10 @@ def avail_easyconfig_templates_rst():
494495
ver = []
495496
ver_desc = []
496497
for name, pref in TEMPLATE_SOFTWARE_VERSIONS:
498+
ver.append('``%%(%smajver)s``' % pref)
497499
ver.append('``%%(%sshortver)s``' % pref)
498500
ver.append('``%%(%sver)s``' % pref)
501+
ver_desc.append('major version for %s' % name)
499502
ver_desc.append('short version for %s (<major>.<minor>)' % name)
500503
ver_desc.append('full version for %s' % name)
501504
table_values = [ver, ver_desc]
@@ -557,8 +560,10 @@ def avail_easyconfig_templates_md():
557560
ver = []
558561
ver_desc = []
559562
for name, pref in TEMPLATE_SOFTWARE_VERSIONS:
563+
ver.append('``%%(%smajver)s``' % pref)
560564
ver.append('``%%(%sshortver)s``' % pref)
561565
ver.append('``%%(%sver)s``' % pref)
566+
ver_desc.append('major version for %s' % name)
562567
ver_desc.append('short version for %s (``<major>.<minor>``)' % name)
563568
ver_desc.append('full version for %s' % name)
564569
table_values = [ver, ver_desc]

test/framework/docs.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -785,6 +785,7 @@ def test_avail_easyconfig_templates(self):
785785
r"^Template names/values derived from easyconfig instance",
786786
r"^\s+%\(version_major\)s: Major version",
787787
r"^Template names/values for \(short\) software versions",
788+
r"^\s+%\(pymajver\)s: major version for Python",
788789
r"^\s+%\(pyshortver\)s: short version for Python \(<major>\.<minor>\)",
789790
r"^Template constants that can be used in easyconfigs",
790791
r"^\s+SOURCE_TAR_GZ: Source \.tar\.gz bundle \(%\(name\)s-%\(version\)s.tar.gz\)",

test/framework/easyconfig.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1290,7 +1290,7 @@ def test_templating_doc(self):
12901290
# expected length: 1 per constant and 2 extra per constantgroup (title + empty line in between)
12911291
temps = [
12921292
easyconfig.templates.TEMPLATE_NAMES_EASYCONFIG,
1293-
easyconfig.templates.TEMPLATE_SOFTWARE_VERSIONS * 2,
1293+
easyconfig.templates.TEMPLATE_SOFTWARE_VERSIONS * 3,
12941294
easyconfig.templates.TEMPLATE_NAMES_CONFIG,
12951295
easyconfig.templates.TEMPLATE_NAMES_LOWER,
12961296
easyconfig.templates.TEMPLATE_NAMES_EASYBLOCK_RUN_STEP,

test/framework/options.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -565,6 +565,7 @@ def run_test(fmt=None):
565565
pattern_lines = [
566566
r'^``%\(version_major\)s``\s+Major version\s*$',
567567
r'^``%\(cudaver\)s``\s+full version for CUDA\s*$',
568+
r'^``%\(cudamajver\)s``\s+major version for CUDA\s*$',
568569
r'^``%\(pyshortver\)s``\s+short version for Python \(<major>.<minor>\)\s*$',
569570
r'^\* ``%\(name\)s``$',
570571
r'^``%\(namelower\)s``\s+lower case of value of name\s*$',
@@ -576,6 +577,7 @@ def run_test(fmt=None):
576577
pattern_lines = [
577578
r'^\s+%\(version_major\)s: Major version$',
578579
r'^\s+%\(cudaver\)s: full version for CUDA$',
580+
r'^\s+%\(cudamajver\)s: major version for CUDA$',
579581
r'^\s+%\(pyshortver\)s: short version for Python \(<major>.<minor>\)$',
580582
r'^\s+%\(name\)s$',
581583
r'^\s+%\(namelower\)s: lower case of value of name$',

0 commit comments

Comments
 (0)