enhance test_sanity_check_only to verify that sanity check for extensions is also run when using --sanity-check-only

Author: boegel

test/framework/options.py

@@ -5783,23 +5783,25 @@ def test_sanity_check_only(self):
             "exts_list = [",
             "    ('barbar', '0.0', {",
             "        'start_dir': 'src',",
+            "        'exts_filter': ('ls -l lib/lib%(ext_name)s.a', ''),",
             "    })",
             "]",
         ])
         write_file(test_ec, test_ec_txt)
 
         # sanity check fails if software was not installed yet
         outtxt, error_thrown = self.eb_main([test_ec, '--sanity-check-only'], do_build=True, return_error=True)
-        self.assertTrue("Sanity check failed: no file found at \\'bin/barbar\\'" in str(error_thrown))
-        self.assertTrue("no file found at \\'bin/toy\\'" in str(error_thrown))
+        self.assertTrue("Sanity check failed" in str(error_thrown))
 
         # actually install, then try --sanity-check-only again;
         # need to use --force to install toy because module already exists (but installation doesn't)
         self.eb_main([test_ec, '--force'], do_build=True, raise_error=True)
 
+        args = [test_ec, '--sanity-check-only']
+
         self.mock_stdout(True)
         self.mock_stderr(True)
-        self.eb_main([test_ec, '--sanity-check-only', '--trace'], do_build=True, raise_error=True, testing=False)
+        self.eb_main(args + ['--trace'], do_build=True, raise_error=True, testing=False)
         stdout = self.get_stdout().strip()
         stderr = self.get_stderr().strip()
         self.mock_stdout(False)
@@ -5830,14 +5832,30 @@ def test_sanity_check_only(self):
         self.assertTrue("== sanity checking..." in stdout)
         self.assertTrue("COMPLETED: Installation ended successfully" in stdout)
         msgs = [
-            "file 'bin/barbar' found: OK",
-            "file 'bin/toy' found: OK",
-            "(non-empty) directory 'bin' found: OK",
-            "loading modules: toy/0.0...",
-            "result for command 'toy': OK",
+            "  >> file 'bin/barbar' found: OK",
+            "  >> file 'bin/toy' found: OK",
+            "  >> (non-empty) directory 'bin' found: OK",
+            "  >> loading modules: toy/0.0...",
+            "  >> result for command 'toy': OK",
+            "ls -l lib/libbarbar.a",  # sanity check for extension barbar (via exts_filter)
         ]
         for msg in msgs:
-            self.assertTrue("  >> %s" % msg in stdout, "'  >> %s' found in: %s" % (msg, stdout))
+            self.assertTrue(msg in stdout, "'%s' found in: %s" % (msg, stdout))
+
+        # check if sanity check for extension fails if a file provided by that extension,
+        # which is checked by the sanity check for that extension, is removed
+        libbarbar = os.path.join(self.test_installpath, 'software', 'toy', '0.0', 'lib', 'libbarbar.a')
+        remove_file(libbarbar)
+
+        outtxt, error_thrown = self.eb_main(args + ['--debug'], do_build=True, return_error=True)
+        error_msg = str(error_thrown)
+        error_patterns = [
+            r"Sanity check failed",
+            r'command "ls -l lib/libbarbar\.a" failed',
+        ]
+        for error_pattern in error_patterns:
+            regex = re.compile(error_pattern)
+            self.assertTrue(regex.search(error_msg), "Pattern '%s' should be found in: %s" % (regex.pattern, error_msg))
 
     def test_fake_vsc_include(self):
         """Test whether fake 'vsc' namespace is triggered for modules included via --include-*."""