don't use %(version)s template in exts_default_options in dumped easyconfig

Author: boegel

easybuild/framework/easyconfig/format/format.py

@@ -52,8 +52,8 @@
 DEPENDENCY_PARAMETERS = ['builddependencies', 'dependencies', 'hiddendependencies']
 
 # values for these keys will not be templated in dump()
-EXCLUDED_KEYS_REPLACE_TEMPLATES = ['description', 'easyblock', 'exts_list', 'homepage', 'name', 'toolchain',
-                                   'version', 'multi_deps'] + DEPENDENCY_PARAMETERS
+EXCLUDED_KEYS_REPLACE_TEMPLATES = ['description', 'easyblock', 'exts_default_options', 'exts_list',
+                                   'homepage', 'multi_deps', 'name', 'toolchain', 'version'] + DEPENDENCY_PARAMETERS
 
 # ordered groups of keys to obtain a nice looking easyconfig file
 GROUPED_PARAMS = [
@@ -69,7 +69,10 @@
     ['preinstallopts', 'installopts'],
     ['parallel', 'maxparallel'],
 ]
-LAST_PARAMS = ['sanity_check_paths', 'moduleclass']
+LAST_PARAMS = ['exts_default_options', 'exts_list',
+               'sanity_check_paths', 'sanity_check_commands',
+               'modextrapaths', 'modextravars',
+               'moduleclass']
 
 SANITY_CHECK_PATHS_DIRS = 'dirs'
 SANITY_CHECK_PATHS_FILES = 'files'

test/framework/easyconfig.py

@@ -1748,7 +1748,7 @@ def test_dump_template(self):
             "easyblock = 'EB_foo'",
             '',
             "name = 'Foo'",
-            "version = '0.0.1'",
+            "version = '1.0.0'",
             "versionsuffix = '-test'",
             '',
             "homepage = 'http://foo.com/'",
@@ -1760,22 +1760,31 @@ def test_dump_template(self):
             '}',
             '',
             "sources = [",
-            "    'foo-0.0.1.tar.gz',",
+            "    'foo-1.0.0.tar.gz',",
             ']',
             '',
             "dependencies = [",
             "    ('bar', '1.2.3', '-test'),",
             ']',
             '',
             "preconfigopts = '--opt1=%s' % name",
-            "configopts = '--opt2=0.0.1'",
+            "configopts = '--opt2=1.0.0'",
             '',
+            'exts_default_options = {',
+            "    'source_urls': ['https://example.com/files/1.0.0'],"
+            '}',
+            'exts_list = [',
+            '  ("ext1", "1.0.0"),'
+            '  ("ext2", "2.1.3"),'
+            ']',
             "sanity_check_paths = {",
             "    'files': ['files/foo/foobar', 'files/x-test'],",
             "    'dirs':[],",
             '}',
             '',
-            "foo_extra1 = 'foobar'"
+            "foo_extra1 = 'foobar'",
+            '',
+            'moduleclass = "tools"',
         ])
 
         handle, testec = tempfile.mkstemp(prefix=self.test_prefix, suffix='.eb')
@@ -1790,7 +1799,7 @@ def test_dump_template(self):
         patterns = [
             r"easyblock = 'EB_foo'",
             r"name = 'Foo'",
-            r"version = '0.0.1'",
+            r"version = '1.0.0'",
             r"versionsuffix = '-test'",
             r"homepage = 'http://foo.com/'",
             r'description = "foo description"',  # no templating for description
@@ -1799,13 +1808,19 @@ def test_dump_template(self):
             # r"dependencies = \[\n    \('bar', '1.2.3', '%\(versionsuffix\)s'\),\n\]",
             r"preconfigopts = '--opt1=%\(name\)s'",
             r"configopts = '--opt2=%\(version\)s'",
+            # no %(version)s template used in exts_default_options or exts_list
+            # see https://github.com/easybuilders/easybuild-framework/issues/3091
+            r"exts_default_options = {'source_urls': \['https://example.com/files/1\.0\.0'\]}",
+            r"\('ext1', '1\.0\.0'\),",
             r"sanity_check_paths = {\n    'files': \['files/%\(namelower\)s/foobar', 'files/x-test'\]",
         ]
 
         for pattern in patterns:
             regex = re.compile(pattern, re.M)
             self.assertTrue(regex.search(ectxt), "Pattern '%s' found in: %s" % (regex.pattern, ectxt))
 
+        ectxt.endswith('moduleclass = "tools"')
+
         # reparsing the dumped easyconfig file should work
         EasyConfig(testec)