Merge pull request #4033 from boegel/check_linked_shared_libs_ldd_fail

make check_linked_shared_libs more robust by taking into account that 'ldd' may fail

Author: branfosj

easybuild/tools/systemtools.py

@@ -57,7 +57,7 @@
     pass
 
 from easybuild.base import fancylogger
-from easybuild.tools.build_log import EasyBuildError
+from easybuild.tools.build_log import EasyBuildError, print_warning
 from easybuild.tools.filetools import is_readable, read_file, which
 from easybuild.tools.py2vs3 import OrderedDict, string_type
 from easybuild.tools.run import run_cmd
@@ -970,7 +970,10 @@ def check_linked_shared_libs(path, required_patterns=None, banned_patterns=None)
         # example output for shared libraries:
         #   /lib64/libc-2.17.so: ELF 64-bit LSB shared object, x86-64, ..., dynamically linked (uses shared libs), ...
         if "dynamically linked" in file_cmd_out:
-            linked_libs_out, _ = run_cmd("ldd %s" % path, simple=False, trace=False)
+            # determine linked libraries via 'ldd', but take into account that 'ldd' may fail for strange reasons,
+            # like printing 'not a dynamic executable' when not enough memory is available
+            # (see also https://bugzilla.redhat.com/show_bug.cgi?id=1817111)
+            linked_libs_cmd = "ldd %s" % path
         else:
             return None
 
@@ -981,12 +984,19 @@ def check_linked_shared_libs(path, required_patterns=None, banned_patterns=None)
         #   /usr/lib/libz.dylib: Mach-O 64-bit dynamically linked shared library x86_64
         bin_lib_regex = re.compile('(Mach-O .* executable)|(dynamically linked)', re.M)
         if bin_lib_regex.search(file_cmd_out):
-            linked_libs_out, _ = run_cmd("otool -L %s" % path, simple=False, trace=False)
+            linked_libs_cmd = "otool -L %s" % path
         else:
             return None
     else:
         raise EasyBuildError("Unknown OS type: %s", os_type)
 
+    out, ec = run_cmd(linked_libs_cmd, simple=False, trace=False, log_ok=False, log_all=False)
+    if ec == 0:
+        linked_libs_out = out
+    else:
+        print_warning("Determining linked libraries for %s via '%s' failed! Output: '%s'", path, linked_libs_cmd, out)
+        return None
+
     found_banned_patterns = []
     missing_required_patterns = []
     for regex in required_regexs:

test/framework/systemtools.py

@@ -1037,6 +1037,33 @@ def test_check_linked_shared_libs(self):
                 error_msg = "Check on linked libs should fail for %s with %s" % (path, pattern_named_args)
                 self.assertFalse(check_linked_shared_libs(path, **pattern_named_args), error_msg)
 
+        if get_os_type() == LINUX:
+            # inject fake 'file' command which always reports that the file is "dynamically linked"
+            file_cmd = os.path.join(self.test_prefix, 'bin', 'file')
+            write_file(file_cmd, "echo '(dynamically linked)'")
+            adjust_permissions(file_cmd, stat.S_IXUSR, add=True)
+
+            os.environ['PATH'] = os.path.join(self.test_prefix, 'bin') + ':' + os.getenv('PATH')
+
+            test_file = os.path.join(self.test_prefix, 'test.txt')
+            write_file(test_file, 'test')
+
+            warning_regex = re.compile(r"WARNING: Determining linked libraries.* via 'ldd .*/test.txt' failed!", re.M)
+
+            self.mock_stderr(True)
+            self.mock_stdout(True)
+            res = check_linked_shared_libs(test_file, banned_patterns=['/lib'])
+            stderr = self.get_stderr()
+            stdout = self.get_stdout()
+            self.mock_stderr(False)
+            self.mock_stdout(False)
+
+            fail_msg = "Pattern '%s' should be found in: %s" % (warning_regex.pattern, stderr)
+            self.assertTrue(warning_regex.search(stderr), fail_msg)
+            self.assertFalse(stdout)
+
+            self.assertEqual(res, None)
+
     def test_locate_solib(self):
         """Test locate_solib function (Linux only)."""
         if get_os_type() == LINUX: