avoid appending directly to from_prs, tidy if/else logic

Author: jfgrimm

easybuild/framework/easyconfig/tools.py

@@ -321,14 +321,14 @@ def alt_easyconfig_paths(tmpdir, tweaked_ecs=False, from_prs=None, review_pr=Non
 
     # paths where files touched in PRs will be downloaded to,
     # which are picked up via 'pr_paths' build option in fetch_files_from_pr
-    pr_paths = None
-    if from_prs and review_pr:
-        from_prs.append(review_pr) if review_pr not in from_prs else from_prs
-    elif review_pr:
-        from_prs = [review_pr]
-
+    pr_paths = []
     if from_prs:
-        pr_paths = [os.path.join(tmpdir, 'files_pr%s' % pr) for pr in from_prs]
+        pr_paths = from_prs
+    if review_pr and review_pr not in pr_paths:
+        pr_paths.append(review_pr)
+
+    if pr_paths:
+        pr_paths = [os.path.join(tmpdir, 'files_pr%s' % pr) for pr in pr_paths]
 
     return tweaked_ecs_paths, pr_paths