Skip to content

Commit 4a647c9

Browse files
committed
Replace Python2-style super-class
The argument is not required in Python3 avoiding C&P mistakes
1 parent bdc066d commit 4a647c9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+189
-190
lines changed

easybuild/base/exceptions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,4 +125,4 @@ def __init__(self, msg, *args, **kwargs):
125125

126126
getattr(logger, self.LOGGING_METHOD_NAME)(msg)
127127

128-
super(LoggedException, self).__init__(msg)
128+
super().__init__(msg)

easybuild/base/frozendict.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,13 @@ def __init__(self, *args, **kwargs):
8787
msg = "Encountered unknown keys %s (known keys: %s)" % (unknown_keys, self.KNOWN_KEYS)
8888
self.log.raiseException(msg, exception=KeyError)
8989

90-
super(FrozenDictKnownKeys, self).__init__(tmpdict)
90+
super().__init__(tmpdict)
9191

9292
# pylint: disable=arguments-differ
9393
def __getitem__(self, key, *args, **kwargs):
9494
"""Redefine __getitem__ to provide a better KeyError message."""
9595
try:
96-
return super(FrozenDictKnownKeys, self).__getitem__(key, *args, **kwargs)
96+
return super().__getitem__(key, *args, **kwargs)
9797
except KeyError as err:
9898
if key in self.KNOWN_KEYS:
9999
raise KeyError(err)

easybuild/base/generaloption.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1745,7 +1745,7 @@ def __init__(self, go_dict=None, short_groupdescr=None, long_groupdescr=None, co
17451745
if config_files is not None:
17461746
kwargs['go_configfiles'] = config_files
17471747

1748-
super(SimpleOption, self).__init__(**kwargs)
1748+
super().__init__(**kwargs)
17491749

17501750
def main_options(self):
17511751
if self.go_dict is not None:

easybuild/base/testing.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def assertEqual(self, a, b, msg=None):
8686
"""Make assertEqual always print useful messages"""
8787

8888
try:
89-
super(TestCase, self).assertEqual(a, b, msg=msg)
89+
super().assertEqual(a, b, msg=msg)
9090
except AssertionError as e:
9191
if not self._is_diffable(a) or not self._is_diffable(b):
9292
raise
@@ -132,7 +132,7 @@ def assertAllExist(self, paths, msg=None):
132132

133133
def setUp(self):
134134
"""Prepare test case."""
135-
super(TestCase, self).setUp()
135+
super().setUp()
136136

137137
self.maxDiff = None
138138
self.longMessage = True
@@ -225,4 +225,4 @@ def tearDown(self):
225225
"""Cleanup after running a test."""
226226
self.mock_stdout(False)
227227
self.mock_stderr(False)
228-
super(TestCase, self).tearDown()
228+
super().tearDown()

easybuild/framework/easyblock.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3253,7 +3253,7 @@ def post_install_step(self):
32533253
- run post install commands if any were specified
32543254
"""
32553255
# even though post_install_step is deprecated in easyblocks we need to keep this here until it is
3256-
# removed in 6.0 for easyblocks calling super(EB_xxx, self).post_install_step()
3256+
# removed in 6.0 for easyblocks calling super().post_install_step()
32573257
# The deprecation warning for those is below, in post_processing_step().
32583258

32593259
lib_dir = os.path.join(self.installdir, 'lib')

easybuild/framework/easyconfig/format/convert.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class Dependency(Convert):
4141

4242
def __init__(self, obj, name=None):
4343
"""Convert pass object to a dependency, use specified name if provided."""
44-
super(Dependency, self).__init__(obj)
44+
super().__init__(obj)
4545
if name is not None:
4646
self['name'] = name
4747

easybuild/framework/easyconfig/format/one.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ class FormatOneZero(EasyConfigFormatConfigObj):
104104

105105
def __init__(self, *args, **kwargs):
106106
"""FormatOneZero constructor."""
107-
super(FormatOneZero, self).__init__(*args, **kwargs)
107+
super().__init__(*args, **kwargs)
108108

109109
self.log = fancylogger.getLogger(self.__class__.__name__, fname=False)
110110
self.strict_sanity_check_paths_keys = True
@@ -155,7 +155,7 @@ def parse(self, txt):
155155
Pre-process txt to extract header, docstring and pyheader, with non-indented section markers enforced.
156156
"""
157157
self.rawcontent = txt
158-
super(FormatOneZero, self).parse(self.rawcontent, strict_section_markers=True)
158+
super().parse(self.rawcontent, strict_section_markers=True)
159159

160160
def _reformat_line(self, param_name, param_val, outer=False, addlen=0):
161161
"""

easybuild/framework/easyconfig/format/pyheaderconfigobj.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ class EasyConfigFormatConfigObj(EasyConfigFormat):
158158

159159
def __init__(self, *args, **kwargs):
160160
"""Extend EasyConfigFormat with some more attributes"""
161-
super(EasyConfigFormatConfigObj, self).__init__(*args, **kwargs)
161+
super().__init__(*args, **kwargs)
162162
self.pyheader_localvars = None
163163
self.configobj = None
164164

easybuild/framework/easyconfig/format/version.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ def versop_regex(self, begin_end=True):
219219
"""
220220
# construct escaped operator symbols, e.g. '\<\='
221221
operators = []
222-
for operator in self.OPERATOR_MAP.keys():
222+
for operator in self.OPERATOR_MAP:
223223
operators.append(re.sub(r'(.)', r'\\\1', operator))
224224

225225
# regex to parse version expression
@@ -477,7 +477,7 @@ def __init__(self, tcversop_str=None):
477477
Initialise VersionOperator instance.
478478
:param tcversop_str: intialise with toolchain version operator string
479479
"""
480-
super(ToolchainVersionOperator, self).__init__()
480+
super().__init__()
481481

482482
self.tc_name = None
483483
self.tcversop_str = None # the full string
@@ -487,7 +487,7 @@ def __init__(self, tcversop_str=None):
487487

488488
def __str__(self):
489489
"""Return string representation of this instance"""
490-
version_str = super(ToolchainVersionOperator, self).__str__()
490+
version_str = super().__str__()
491491
return ''.join(map(str, [self.tc_name, self.SEPARATOR, version_str]))
492492

493493
def __hash__(self):
@@ -511,7 +511,7 @@ def is_valid(self):
511511
"""Check if this is a valid ToolchainVersionOperator"""
512512
tc_names = self._get_all_toolchain_names()
513513
known_tc_name = self.tc_name in tc_names
514-
return known_tc_name and super(ToolchainVersionOperator, self).is_valid()
514+
return known_tc_name and super().is_valid()
515515

516516
def set(self, tcversop_str):
517517
"""
@@ -535,7 +535,7 @@ def versop_regex(self):
535535
tc_names = self._get_all_toolchain_names()
536536
self.log.debug("found toolchain names %s" % tc_names)
537537

538-
versop_regex = super(ToolchainVersionOperator, self).versop_regex(begin_end=False)
538+
versop_regex = super().versop_regex(begin_end=False)
539539
versop_pattern = r'(?P<versop_str>%s)' % versop_regex.pattern
540540
tc_names_regex = r'(?P<tc_name>(?:%s))' % '|'.join(tc_names)
541541
tc_regex = re.compile(r'^%s(?:%s%s)?$' % (tc_names_regex, self.SEPARATOR, versop_pattern))
@@ -556,7 +556,7 @@ def parse_versop_str(self, tcversop_str):
556556
tcversop_dict = res.groupdict()
557557
tcversop_dict['tcversop_str'] = tcversop_str # the total string
558558

559-
tcversop_dict = super(ToolchainVersionOperator, self).parse_versop_str(None, versop_dict=tcversop_dict)
559+
tcversop_dict = super().parse_versop_str(None, versop_dict=tcversop_dict)
560560

561561
if tcversop_dict.get('version_str', None) is not None and tcversop_dict.get('operator_str', None) is None:
562562
raise EasyBuildError("Toolchain version found, but no operator (use ' == '?).")
@@ -586,7 +586,7 @@ def test(self, name, version):
586586
tc_name_res = name == self.tc_name
587587
if not tc_name_res:
588588
self.log.debug('Toolchain name %s different from test toolchain name %s' % (self.tc_name, name))
589-
version_res = super(ToolchainVersionOperator, self).test(version)
589+
version_res = super().test(version)
590590
res = tc_name_res and version_res
591591
self.log.debug("result of testing expression tc_name_res %s version_res %s: %s", tc_name_res, version_res, res)
592592

easybuild/framework/extensioneasyblock.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,9 @@ def sanity_check_step(self, exts_filter=None, custom_paths=None, custom_commands
200200
self.clean_up_fake_module(fake_mod_data)
201201

202202
if custom_paths or custom_commands or not self.is_extension:
203-
super(ExtensionEasyBlock, self).sanity_check_step(custom_paths=custom_paths,
204-
custom_commands=custom_commands,
205-
extension=self.is_extension)
203+
super().sanity_check_step(custom_paths=custom_paths,
204+
custom_commands=custom_commands,
205+
extension=self.is_extension)
206206

207207
# pass or fail sanity check
208208
if sanity_check_ok:

0 commit comments

Comments
 (0)