don't let setting --prefix configuration option imply that --failed-installs-build-dirs-path and --failed-installs-logs-path are also set with a default subdirectory, they should be used opt-in

Author: boegel

easybuild/tools/config.py

@@ -104,12 +104,9 @@
 DEFAULT_MNS = 'EasyBuildMNS'
 DEFAULT_MODULE_SYNTAX = 'Lua'
 DEFAULT_MODULES_TOOL = 'Lmod'
-FAILED_INSTALLS_SUBDIR = 'failed-installs'
 DEFAULT_PATH_SUBDIRS = {
     'buildpath': 'build',
     'containerpath': 'containers',
-    'failed_installs_build_dirs_path': os.path.join(FAILED_INSTALLS_SUBDIR, 'build-dirs'),
-    'failed_installs_logs_path': os.path.join(FAILED_INSTALLS_SUBDIR, 'logs'),
     'installpath': '',
     'packagepath': 'packages',
     'repositorypath': 'ebfiles_repo',

easybuild/tools/options.py

@@ -1218,7 +1218,7 @@ def _postprocess_config(self):
         # to avoid incorrect paths being used when EasyBuild changes the current working directory
         # (see https://github.com/easybuilders/easybuild-framework/issues/3619);
         # ensuring absolute paths for 'robot' is handled separately below,
-        # because we need to be careful with the argument pass to --robot;
+        # because we need to be careful with the argument passed to --robot;
         # note: repositorypath is purposely not listed here, because it's a special case:
         # - the value could consist of a 2-tuple (<path>, <relative_subdir>);
         # - the <path> could also specify the location of a *remote* (Git( repository,
@@ -1232,10 +1232,11 @@ def _postprocess_config(self):
             self._ensure_abs_path(opt_name)
 
         if self.options.prefix is not None:
-            # prefix applies to all paths, and repository has to be reinitialised to take new repositorypath in account
-            # in the legacy-style configuration, repository is initialised in configuration file itself
-            path_opts = ['buildpath', 'containerpath', 'failed_installs_build_dirs_path', 'failed_installs_logs_path',
-                         'installpath', 'packagepath', 'repository', 'repositorypath', 'sourcepath']
+            # prefix applies to selected path configuration options;
+            # repository has to be reinitialised to take new repositorypath in account;
+            # in the legacy-style configuration, repository is initialised in configuration file itself;
+            path_opts = ['buildpath', 'containerpath', 'installpath', 'packagepath', 'repository', 'repositorypath',
+                         'sourcepath']
             for dest in path_opts:
                 if not self.options._action_taken.get(dest, False):
                     if dest == 'repository':

test/framework/options.py

@@ -5462,8 +5462,6 @@ def test_prefix_option(self):
         expected = [
             'buildpath',
             'containerpath',
-            'failed-installs-build-dirs-path',
-            'failed-installs-logs-path',
             'installpath',
             'packagepath',
             'prefix',